-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I2C: support 10-bit addressing #2507
Comments
There's some precedence for this in the I8080 driver. Just want to note that the decision made here could also be made there as well, for consistency sake.
Might be worth considering whether this can also be reused for the slave driver in future, as that may influence the decision. |
I'm just not entirely in love with the idea that users will need to add |
In theory after #2864 this is not strictly a blocker since we should be able to add 10-bit addressing support in a non-breaking way later |
I agree, I think that fact we can support this post 1.0 is enough now. 10bit support is rare enough that I don't think we need this for 1.0. |
As noted by #2493 (comment)
We have a few options to support 10-bit addressing in inherent methods:
_10b
methodsenum Address {Seven(u8), Ten(u16)}
- too verbose?impl TryInto<Address>
and let the user pass eitheru8
oru16
- too implicit?AddressMode
enum, and always takeaddress: u16
Any other, perhaps better ideas?
The text was updated successfully, but these errors were encountered: