Questions about BAT0 or BAT1 in battery.sh

[ycpss91255]

it doesn't exist on my lattop (LG, Ubuntu 24.04 and Ubuntu 20.04). My laptop only has CMB0. I replaced BAT0 in .sh with CMB0 to make it work properly.

[erikw]

Oh look at that. It looks like this code should be a bit smarter and not just assume two names (BAT0 or BAT1):

tmux-powerline/segments/battery.sh

Lines 107 to 109 in 59b7648

	BATPATH=/sys/class/power_supply/BAT0
	if [ ! -d $BATPATH ]; then
	BATPATH=/sys/class/power_supply/BAT1

We could look for these most common names (BAT0 or BAT1), or else pick the one other battery name (if any) if those two first one does not exist.

Would you be willing to make a PR? :)

[xx4h]

This has been closed accidentally. The issue is about CMB?-naming instead of BAT?, while the referenced and merged PR is about having multiple BAT? (instead of only supporting hard coded BAT0 and BAT1)

I see two reasonable approaches

1. Clean implementation
   We get all power supply entries with type=Battery.

while read bat; do
        local full="$bat/charge_full"
        local now="$bat/charge_now"
        ...
done <<<$(grep -l "Battery" /sys/class/power_supply/*/type | sed -e 's,/type$,,')

2. Quick Fix
   We add CMB* to the loop

for bat in /sys/class/power_supply/{BAT,CMB}*; do
    ...

Of course i'll recommend 1., will make a PR as soon as we're aligned.

[erikw]

Oh yes you are correct, I incorrectly linked this issue to the mentioned PR. Sorry! Thanks for noticing:)