Fix COBSPrint::abort() and add PacketPrint::reset() #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abort() did not reset the leftover buffer, causing the aborted packet to be retried. It also didn't reset the counter correctly.
This method allows a new packet to be started even if we are in the middle of writing the previous packet. No attempt is made to make sure the transition between packets is valid.
eric-wieser
reviewed
Dec 14, 2022
| } | ||
|
|
||
| virtual void abort() override { | ||
| _counter = 0; |
Owner
There was a problem hiding this comment.
Nice catch. Sorry for not spotting this PR two years ago...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COBSPrint::abort()has two bugs: the leftover buffer is not reset, causing old data to be printed after the abort, and the counter is reset to 0 instead of 1, causing the next packet to fail.For my application, I need the ability to reset the internal packet state without trying to terminate the current packet, so I added the
PacketPrint::reset()method.These changes build off each other, so I put them in the same PR.