Merge pull request #622 from ergoplatform/clippy_rustc_1_63

Fix clippy warnings for rustc 1.63 and update CI

Author: greenhat

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ on:
       - synchronize
 
 env:
-  RUSTV: '1.62'
+  RUSTV: '1.63'
 
 jobs:
   build_wo_default_features:

bindings/ergo-lib-c-core/src/context_extension.rs

@@ -5,7 +5,7 @@ use crate::{
 use ergo_lib::ergotree_interpreter::sigma_protocol::prover;
 
 /// User-defined variables to be put into context
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct ContextExtension(pub prover::ContextExtension);
 pub type ContextExtensionPtr = *mut ContextExtension;
 pub type ConstContextExtensionPtr = *const ContextExtension;

bindings/ergo-lib-c-core/src/data_input.rs

@@ -9,7 +9,7 @@ use crate::{
 };
 
 /// Inputs, that are used to enrich script context, but won't be spent by the transaction
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct DataInput(pub chain::transaction::DataInput);
 pub type DataInputPtr = *mut DataInput;
 pub type ConstDataInputPtr = *const DataInput;

bindings/ergo-lib-c-core/src/input.rs

@@ -10,7 +10,7 @@ use crate::{
 };
 
 /// Unsigned inputs used in constructing unsigned transactions
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct UnsignedInput(pub chain::transaction::UnsignedInput);
 pub type UnsignedInputPtr = *mut UnsignedInput;
 pub type ConstUnsignedInputPtr = *const UnsignedInput;
@@ -40,7 +40,7 @@ pub unsafe fn unsigned_input_context_extension(
 }
 
 /// Signed inputs used in signed transactions
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct Input(pub(crate) chain::transaction::Input);
 pub type InputPtr = *mut Input;
 pub type ConstInputPtr = *const Input;
@@ -70,7 +70,7 @@ pub unsafe fn input_spending_proof(
 }
 
 /// Proof of correctness of tx spending
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct ProverResult(chain::transaction::input::prover_result::ProverResult);
 pub type ProverResultPtr = *mut ProverResult;
 pub type ConstProverResultPtr = *const ProverResult;

bindings/ergo-lib-c-core/src/reduced.rs

@@ -51,7 +51,7 @@ pub unsafe fn propositions_add_proposition_from_bytes(
 /// in an environment where secrets are known.
 /// see EIP-19 for more details -
 /// <https://github.com/ergoplatform/eips/blob/f280890a4163f2f2e988a0091c078e36912fc531/eip-0019.md>
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct ReducedTransaction(pub(crate) ergo_lib::chain::transaction::reduced::ReducedTransaction);
 pub type ReducedTransactionPtr = *mut ReducedTransaction;
 pub type ConstReducedTransactionPtr = *const ReducedTransaction;

bindings/ergo-lib-c-core/src/secret_key.rs

@@ -8,7 +8,7 @@ use crate::util::{const_ptr_as_ref, mut_ptr_as_mut};
 use crate::Error;
 
 /// Secret key for the prover
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct SecretKey(pub(crate) wallet::secret_key::SecretKey);
 pub type SecretKeyPtr = *mut SecretKey;
 pub type ConstSecretKeyPtr = *const SecretKey;

bindings/ergo-lib-c-core/src/transaction.rs

@@ -165,7 +165,7 @@ pub unsafe fn transaction_extract_hints(
 }
 
 /// Unsigned (inputs without proofs) transaction
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct UnsignedTransaction(pub(crate) chain::transaction::unsigned::UnsignedTransaction);
 pub type UnsignedTransactionPtr = *mut UnsignedTransaction;
 pub type ConstUnsignedTransactionPtr = *const UnsignedTransaction;

bindings/ergo-lib-wasm/src/context_extension.rs

@@ -9,7 +9,7 @@ use derive_more::{From, Into};
 
 /// User-defined variables to be put into context
 #[wasm_bindgen]
-#[derive(PartialEq, Debug, Clone, From, Into)]
+#[derive(PartialEq, Eq, Debug, Clone, From, Into)]
 pub struct ContextExtension(
     ergo_lib::ergotree_interpreter::sigma_protocol::prover::ContextExtension,
 );

bindings/ergo-lib-wasm/src/input.rs

@@ -11,7 +11,7 @@ use derive_more::{From, Into};
 
 /// Unsigned inputs used in constructing unsigned transactions
 #[wasm_bindgen]
-#[derive(PartialEq, Debug, Clone, From, Into)]
+#[derive(PartialEq, Eq, Debug, Clone, From, Into)]
 pub struct UnsignedInput(chain::transaction::UnsignedInput);
 
 #[wasm_bindgen]
@@ -47,7 +47,7 @@ impl UnsignedInput {
 
 /// Collection of unsigned signed inputs
 #[wasm_bindgen]
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct UnsignedInputs(Vec<UnsignedInput>);
 
 #[wasm_bindgen]
@@ -87,7 +87,7 @@ impl From<Vec<chain::transaction::UnsignedInput>> for UnsignedInputs {
 
 /// Signed inputs used in signed transactions
 #[wasm_bindgen]
-#[derive(PartialEq, Debug, Clone, From, Into)]
+#[derive(PartialEq, Eq, Debug, Clone, From, Into)]
 pub struct Input(chain::transaction::Input);
 
 #[wasm_bindgen]
@@ -105,7 +105,7 @@ impl Input {
 
 /// Collection of signed inputs
 #[wasm_bindgen]
-#[derive(PartialEq, Debug, Clone)]
+#[derive(PartialEq, Eq, Debug, Clone)]
 pub struct Inputs(Vec<Input>);
 
 #[wasm_bindgen]

bindings/ergo-lib-wasm/src/prover_result.rs

@@ -8,7 +8,7 @@ use derive_more::{From, Into};
 
 /// Proof of correctness of tx spending
 #[wasm_bindgen]
-#[derive(PartialEq, Debug, Clone, From, Into)]
+#[derive(PartialEq, Eq, Debug, Clone, From, Into)]
 pub struct ProverResult(ergo_lib::chain::transaction::input::prover_result::ProverResult);
 
 #[wasm_bindgen]