Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of index operations #65

Closed
madadam opened this issue Jul 29, 2022 · 2 comments
Closed

Improve performance of index operations #65

madadam opened this issue Jul 29, 2022 · 2 comments

Comments

@madadam
Copy link
Collaborator

madadam commented Jul 29, 2022

Currently the operations on the index (BranchData::get, BranchData::insert and BranchData::remove) are quite expensive. Things are especially bad if multiple such operations need to be executed within a db transaction (for example in fork) because then we hold the db connection until all of the operations are complete which blocks other parts of the system that also need db connection.

We should first create some benchmarks (perhaps using criterion) and then explore ways to optimize this code.

@madadam
Copy link
Collaborator Author

madadam commented Sep 6, 2023

Related: #131

@madadam
Copy link
Collaborator Author

madadam commented Nov 15, 2023

Done in a6fe1d8

@madadam madadam closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant