PHP 8.5 deprecation: imagedestroy() has no effect since PHP 8.0

[mxmsmnv]

Environment

• PHP 8.5
• FieldtypeQRCode.module
• GIF QR-code output (generateRawQRCode($text, false, ...))

Problem

Generating a GIF QR code emits:

PHP Deprecated: Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

The call is currently made after imagegif($im) in FieldtypeQRCode::generateRawQRCode().

Suggested change

Only call imagedestroy() on PHP versions older than 8.0, or remove the call if PHP 8+ is the minimum supported version:

imagegif($im);
if (PHP_VERSION_ID < 80000) {
    imagedestroy($im);
}

GD objects are released automatically on PHP 8+, so this preserves compatibility with older PHP versions while avoiding the PHP 8.5 deprecation.

[romaincazier]

Hi @mxmsmnv,

Which version of the module are you using?

This was fixed in v1.1.3 following an issue opened by @adrianbj, see commit 7d5bd87

[mxmsmnv]

Which version of the module are you using?

1.0.15

[romaincazier]

Did you try to update the module?

If you have any issue please let me know otherwise please close this issue.