Skip to content

Conversation

@NayanPahuja
Copy link
Contributor

What type of PR is this?
feat(api): Added support for weighted field in BackendRef

What this PR does / why we need it:

@NayanPahuja NayanPahuja requested a review from a team as a code owner November 8, 2025 07:25
@NayanPahuja
Copy link
Contributor Author

NayanPahuja commented Nov 8, 2025

cc: @arkodg
Made core functional changes and tested locally.

Will need your help on what tests should I exactly write for this PR. I will make the necessary changes to the same PR.

Edit:

Also I see that since BackendRef is referenced other places such as the down below. Let me know if any subsequent changes are required since these might be impacted as well.

ALSEnvoyProxyAccessLog
BackendCluster
ExtProc
GRPCExtAuthService
HTTPExtAuthService
OIDCProvider
OpenTelemetryEnvoyProxyAccessLog
ProxyOpenTelemetrySink
RemoteJWKS
TracingProvider

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.30%. Comparing base (4784e5a) to head (7a5793e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7452      +/-   ##
==========================================
+ Coverage   72.27%   72.30%   +0.03%     
==========================================
  Files         232      232              
  Lines       34109    34114       +5     
==========================================
+ Hits        24653    24667      +14     
+ Misses       7680     7673       -7     
+ Partials     1776     1774       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg
Copy link
Contributor

arkodg commented Nov 22, 2025

hey @NayanPahuja thanks for filling this gap, the code LGTM
can you also add a test case in https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata to make sure IR->xDS translation exists for ext service

@arkodg arkodg added this to the v1.7.0-rc.1 Release milestone Nov 22, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team November 23, 2025 16:54
@arkodg arkodg merged commit 45af0ef into envoyproxy:main Nov 26, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support weight field for non x-routes

3 participants