-
Notifications
You must be signed in to change notification settings - Fork 597
api: Added support for weighted field in BackendRef #7452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Added support for weighted field in BackendRef #7452
Conversation
…process Signed-off-by: Nayan <[email protected]>
Signed-off-by: Nayan <[email protected]>
Signed-off-by: Nayan <[email protected]>
Signed-off-by: Nayan <[email protected]>
Signed-off-by: Nayan <[email protected]>
|
cc: @arkodg Will need your help on what tests should I exactly write for this PR. I will make the necessary changes to the same PR. Edit: Also I see that since BackendRef is referenced other places such as the down below. Let me know if any subsequent changes are required since these might be impacted as well. ALSEnvoyProxyAccessLog |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7452 +/- ##
==========================================
+ Coverage 72.27% 72.30% +0.03%
==========================================
Files 232 232
Lines 34109 34114 +5
==========================================
+ Hits 24653 24667 +14
+ Misses 7680 7673 -7
+ Partials 1776 1774 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Nayan <[email protected]>
Signed-off-by: Nayan <[email protected]>
|
hey @NayanPahuja thanks for filling this gap, the code LGTM |
Signed-off-by: Nayan <[email protected]>
Signed-off-by: Nayan <[email protected]>
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
What type of PR is this?
feat(api): Added support for weighted field in BackendRef
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes Support weight field for non x-routes #7449
Release Notes: Yes