Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Certificate Rotation #3398

Closed
blakeromano opened this issue May 15, 2024 · 5 comments
Closed

Automatic Certificate Rotation #3398

blakeromano opened this issue May 15, 2024 · 5 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Milestone

Comments

@blakeromano
Copy link

Description:
Similar to Emissary Ingress we are creating a certificate on creation and it has a static expiration of 5 years (emissary does 1 year) with no automatic refresh: emissary-ingress/emissary#4442

We should have a way to opt in to allow Cert Manager to control refreshes of certificates and automatically do restarts or any other necessary processes to ensure rotations incur 0 downtime.

@arkodg
Copy link
Contributor

arkodg commented May 15, 2024

there's a guide for cert manager integration in https://gateway.envoyproxy.io/v1.0.1/install/custom-cert/

and there's also a knob to overwriteControlPlaneCerts by the EG Job during upgrades
https://gateway.envoyproxy.io/v1.0.1/api/extension_types/#envoygatewaykubernetesprovider

keeping this issue open for someone from the community to improve the docs

@arkodg arkodg added documentation Improvements or additions to documentation help wanted Extra attention is needed and removed triage labels May 15, 2024
@arkodg arkodg added this to the Backlog milestone May 15, 2024
@blakeromano
Copy link
Author

blakeromano commented May 15, 2024

If Certificate Manager is used what downtime is incurred by Certificate Manager rotating the certificate or CA?

@guydc
Copy link
Contributor

guydc commented Dec 17, 2024

related: #4891

@guydc
Copy link
Contributor

guydc commented Jan 9, 2025

@blakeromano

If Certificate Manager is used what downtime is incurred by Certificate Manager rotating the certificate or CA?

It really depends on how you're using EG. For example, I expect that you would only experience an impact if you're using a feature like rate-limiting. This would also depend on the volume of traffic that you have and how many new connections from Envoy to Rate Limit would be established while Certs are not in sync.

From my limited testing, it can take up to a minute for two for K8s to refresh the mounted secrets and envoy to pick it up.

@arkodg
Copy link
Contributor

arkodg commented Jan 9, 2025

closing this in favor of #4891

@arkodg arkodg closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants