Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide necessary license and documentation for envoy Jaeger tracing plugin to ensure open source designation #19554

Closed
cjp421 opened this issue Jan 14, 2022 · 8 comments
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@cjp421
Copy link

cjp421 commented Jan 14, 2022

Title: Provide necessary license and documentation for envoy Jaeger tracing plugin to ensure open source designation

Description:

I would like to leverage the Jaeger Tracing plugin within my organization's envoy docker containers. In order for this to be allowed, I need to provide evidence that the plugin uses a support license agreement. I have submitted envoyproxy/misc#1 requesting for a license to be specified and the README updated to provide a reference to the source code used to generate the plugin.

Relevant Links:

Related conversation - jaegertracing/jaeger-client-cpp#183 (comment)
Reference to plugin in envoy examples: https://github.com/envoyproxy/envoy/blob/main/examples/jaeger-native-tracing/Dockerfile-frontenvoy#L14-L17

@cjp421 cjp421 added the triage Issue requires triage label Jan 14, 2022
@alyssawilk alyssawilk added question Questions that are neither investigations, bugs, nor enhancements and removed triage Issue requires triage labels Jan 14, 2022
@alyssawilk
Copy link
Contributor

cc @htuch @phlax

@phlax
Copy link
Member

phlax commented Jan 14, 2022

cc @lizan

@cjp421
Copy link
Author

cjp421 commented Feb 8, 2022

Any updates on this?

@phlax
Copy link
Member

phlax commented Feb 8, 2022

not sure what the license situation is exactly - i added (or maybe updated) the binary to fix an issue with abi incompatibility some time ago

the binary i added was iirc from a tetrate recipe, i think @lizan knows more about where it came from originally - the url has since been shifted to within the envoyproxy namespace, so i assume its Apache licensed - but not sure and not sure where the source/compile recipe is etc

ideally with this we add some bazel build to build this plugin in envoys ci and then we wont have to worry about this so much or the other concerns iwith hosting a binary in the repo

@cjp421
Copy link
Author

cjp421 commented Mar 10, 2022

@lizan can you provide any insights into the licensing around the jaeger plugin for envoy? Would it be possible to get the changes you made committed to github with the relevant LICENSE file? Or possibly add a LICENSE file to the envoyproxy/misc repository?

@lizan
Copy link
Member

lizan commented Mar 11, 2022

Yes it is Apache license. the Jaeger opentracing C++ library is already deprecated so I don't think we want to invest more in this.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 10, 2022
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

4 participants