deps: migrate zstd to BCR-compatible native Bazel build for bzlmod

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

bazel/external/zstd.BUILD

@@ -0,0 +1,112 @@
+load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
+
+package(default_visibility = ["//visibility:public"])
+
+filegroup(
+    name = "common_sources",
+    srcs = glob([
+        "lib/common/*.c",
+        "lib/common/*.h",
+    ]),
+)
+
+filegroup(
+    name = "compress_sources",
+    srcs = glob([
+        "lib/compress/*.c",
+        "lib/compress/*.h",
+    ]),
+)
+
+filegroup(
+    name = "decompress_sources",
+    srcs = glob([
+        "lib/decompress/*.c",
+        "lib/decompress/*.h",
+    ]) + select({
+        "@platforms//os:windows": [],
+        "//conditions:default": glob(["lib/decompress/*.S"]),
+    }),
+)
+
+filegroup(
+    name = "dictbuilder_sources",
+    srcs = glob([
+        "lib/dictBuilder/*.c",
+        "lib/dictBuilder/*.h",
+    ]),
+)
+
+cc_library(
+    name = "zstd",
+    srcs = [
+        ":common_sources",
+        ":compress_sources",
+        ":decompress_sources",
+        ":dictbuilder_sources",
+    ],
+    hdrs = [
+        "lib/zdict.h",
+        "lib/zstd.h",
+        "lib/zstd_errors.h",
+    ],
+    includes = ["lib"],
+    linkopts = ["-pthread"],
+    linkstatic = True,
+    local_defines = [
+        "XXH_NAMESPACE=ZSTD_",
+        "ZSTD_MULTITHREAD",
+        "ZSTD_BUILD_SHARED=OFF",
+        "ZSTD_BUILD_STATIC=ON",
+    ] + select({
+        "@platforms//os:windows": ["ZSTD_DISABLE_ASM"],
+        "//conditions:default": [],
+    }),
+)
+
+cc_library(
+    name = "util",
+    srcs = [
+        "programs/platform.h",
+        "programs/util.c",
+    ],
+    hdrs = [
+        "lib/common/compiler.h",
+        "lib/common/debug.h",
+        "lib/common/mem.h",
+        "lib/common/portability_macros.h",
+        "lib/common/zstd_deps.h",
+        "programs/util.h",
+    ],
+)
+
+cc_library(
+    name = "datagen",
+    srcs = [
+        "programs/datagen.c",
+        "programs/platform.h",
+    ],
+    hdrs = ["programs/datagen.h"],
+    deps = [":util"],
+)
+
+cc_binary(
+    name = "zstd_cli",
+    srcs = glob(
+        include = [
+            "programs/*.c",
+            "programs/*.h",
+        ],
+        exclude = [
+            "programs/datagen.c",
+            "programs/datagen.h",
+            "programs/platform.h",
+            "programs/util.h",
+        ],
+    ),
+    deps = [
+        ":datagen",
+        ":util",
+        ":zstd",
+    ],
+)

bazel/foreign_cc/BUILD

@@ -540,40 +540,10 @@ envoy_cmake(
     }),
 )
 
-envoy_cmake(
+alias(
     name = "zstd",
-    build_args = select({
-        "//bazel/foreign_cc:parallel_builds_enabled": ["-j"],
-        "//bazel:engflow_rbe_x86_64": ["-j"],
-        "//bazel:engflow_rbe_aarch64": ["-j"],
-        "//conditions:default": ["-j1"],
-    }),
-    build_data = ["@com_github_facebook_zstd//:all"],
-    cache_entries = {
-        "CMAKE_BUILD_TYPE": "Release",
-        "CMAKE_INSTALL_LIBDIR": "lib",
-        "ZSTD_BUILD_SHARED": "off",
-        "ZSTD_BUILD_STATIC": "on",
-    },
-    exec_properties = select({
-        "//bazel:engflow_rbe_x86_64": {
-            "Pool": "linux_x64_large",
-        },
-        "//bazel:engflow_rbe_aarch64": {
-            "Pool": "linux_arm64_small",
-        },
-        "//conditions:default": {},
-    }),
-    generate_args = [
-        "-G",
-        "Ninja",
-    ],
-    lib_source = "@com_github_facebook_zstd//:all",
-    out_static_libs = select({
-        "//bazel:windows_x86_64": ["zstd_static.lib"],
-        "//conditions:default": ["libzstd.a"],
-    }),
-    working_directory = "build/cmake",
+    actual = "@com_github_facebook_zstd//:zstd",
+    visibility = ["//visibility:public"],
 )
 
 envoy_cmake(

bazel/repositories.bzl

@@ -506,7 +506,7 @@ def _org_brotli():
 def _com_github_facebook_zstd():
     external_http_archive(
         name = "com_github_facebook_zstd",
-        build_file_content = BUILD_ALL_CONTENT,
+        build_file = "@envoy//bazel/external:zstd.BUILD",
     )
 
 def _com_google_cel_cpp():

source/common/compression/zstd/common/base.h

@@ -4,7 +4,7 @@
 
 #include "envoy/buffer/buffer.h"
 
-#include "zstd.h"
+#include "lib/zstd.h"
 
 namespace Envoy {
 namespace Compression {

source/extensions/compression/zstd/common/dictionary_manager.h

@@ -7,7 +7,7 @@
 
 #include "source/common/config/datasource.h"
 
-#include "zstd.h"
+#include "lib/zstd.h"
 
 namespace Envoy {
 namespace Extensions {

tools/zstd/BUILD

@@ -1,9 +1,7 @@
-load(":zstd.bzl", "zstd")
-
 licenses(["notice"])  # Apache 2
 
-zstd(
+alias(
     name = "zstd",
-    target = "//bazel/foreign_cc:zstd",
+    actual = "@com_github_facebook_zstd//:zstd_cli",
     visibility = ["//visibility:public"],
 )