dynamic modules: enhanced ABI to support header addition and body size retrieval (#41908)

Commit Message: dynamic modules: enhanced ABI to support header addition
and body size retrieval
Additional Description:

1. New ABI to support header addition. By this way users could append
header value rather than only overwrite.
2. New ABI to get body size without read the body content.
3. naming change: body_vector -> body_chunks
4. Updated the get_header and get_headers ABI to use return value as
status and parameter as output.
5. All the structs and enums types have a name. This is necessary for
CGO to identify it correctly.

Risk Level: low.
Testing: unit/integration.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.

---------

Signed-off-by: wbpcode <[email protected]>

Author: wbpcode

changelogs/current.yaml

@@ -147,6 +147,10 @@ new_features:
   change: |
     Support process-level rate limiting on access log emission by
     :ref:`ProcessRateLimitFilter <envoy_v3_api_msg_extensions.access_loggers.filters.process_ratelimit.v3.ProcessRateLimitFilter>`.
+- area: dynamic modules
+  change: |
+    Enhanced dynamic module ABIs to support headers addition and body size retrieval.
+    See the latest ABI header file for more details.
 - area: udp_sink
   change: |
     Enhanced the UDP sink to support tapped messages larger than 64 KB.

source/extensions/dynamic_modules/abi.h

@@ -6,7 +6,7 @@ namespace DynamicModules {
 #endif
 // This is the ABI version calculated as a sha256 hash of the ABI header files. When the ABI
 // changes, this value must change, and the correctness of this value is checked by the test.
-const char* kAbiVersion = "52972436b8fd594556e76e1f9adfe1c22b7fd4a6bd3bbe6d9cdc8e0d7903dc68";
+const char* kAbiVersion = "cb4b1a2acfcb8b68e74f754d8a9197e64eb3b926056d4054971b86eee6f19d95";
 
 #ifdef __cplusplus
 } // namespace DynamicModules

source/extensions/dynamic_modules/abi_version.h

@@ -52,7 +52,7 @@ impl bindgen::callbacks::ParseCallbacks for TrimEnumNameFromVariantName {
   ) -> Option<String> {
     let variant_name = match enum_name {
       Some(enum_name) => original_variant_name
-        .trim_start_matches(enum_name)
+        .trim_start_matches(enum_name.trim_start_matches("enum "))
         .trim_start_matches('_'),
       None => original_variant_name,
     };

source/extensions/dynamic_modules/sdk/rust/build.rs

@@ -170,11 +170,11 @@ void DynamicModuleHttpFilter::HttpCalloutCallback::onSuccess(const AsyncClient::
     return;
   }
 
-  absl::InlinedVector<envoy_dynamic_module_type_http_header, 16> headers_vector;
+  absl::InlinedVector<envoy_dynamic_module_type_envoy_http_header, 16> headers_vector;
   headers_vector.reserve(response->headers().size());
   response->headers().iterate([&headers_vector](
                                   const Http::HeaderEntry& header) -> Http::HeaderMap::Iterate {
-    headers_vector.emplace_back(envoy_dynamic_module_type_http_header{
+    headers_vector.emplace_back(envoy_dynamic_module_type_envoy_http_header{
         const_cast<char*>(header.key().getStringView().data()), header.key().getStringView().size(),
         const_cast<char*>(header.value().getStringView().data()),
         header.value().getStringView().size()});

source/extensions/dynamic_modules/sdk/rust/src/lib.rs

@@ -1,5 +1,5 @@
 #include "source/extensions/dynamic_modules/abi.h"
 
-envoy_dynamic_module_type_abi_version_envoy_ptr envoy_dynamic_module_on_program_init() {
+envoy_dynamic_module_type_abi_version_module_ptr envoy_dynamic_module_on_program_init() {
   return "invalid-version-hash";
 }

source/extensions/filters/http/dynamic_modules/abi_impl.cc

@@ -3,7 +3,7 @@
 #include "source/extensions/dynamic_modules/abi.h"
 #include "source/extensions/dynamic_modules/abi_version.h"
 
-envoy_dynamic_module_type_abi_version_envoy_ptr envoy_dynamic_module_on_program_init() {
+envoy_dynamic_module_type_abi_version_module_ptr envoy_dynamic_module_on_program_init() {
   return kAbiVersion;
 }