Skip to content

Commit c9509df

Browse files
committed
cleaning up language.
1 parent 92c7e6c commit c9509df

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ good code and ideas to the Skulpt. This list may change over time as people gai
9797
Skulpt. If you would like to volunteer contact Brad.
9898

9999
Although a lot of our testing, and checking for adherence to the style guidelines is done automatically
100-
the review process is generally as follows:
100+
the review process I would recommend for committers is as follows:
101101

102-
1. Look at the diffs for each file on github, if it is pretty obvious what they are doing then great.
102+
1. Look at the diffs for each file on github, if it is pretty obvious what they are doing is correct then that is a good sign.
103103
2. Look at the tests provided with the PR and try to think if there are additional tests that would provide better coverage. If you think additional tests are needed then you should let the owner of the PR know and have them add more tests. All new PRs that are adding new features should be using the new unittest framework, not the old numbered framework.
104-
3. Pull the the PR down to your local machine and run all the tests manually locally. (Unless it is really trivial)
104+
3. Pull the the PR down to your local machine and run all the tests locally. (Unless it is really trivial)
105105
4. If the code looked a bit more complicated when you examined the diffs, then you should bring it up in your editor and look over the code in context and try to understand it better. If there are issues with how the code is written or if it is unclear about why something was done, then have that conversation with the owner of the PR.
106106
5. Many of us have our own projects that exercise Skulpt to its limits. If you are particularly concerned about a PR then you may want to try out the built js files in your environment.
107107
6. It is always appropriate to raise questions and have a group conversation about anything that looks particularly problematic or risky.

0 commit comments

Comments
 (0)