Skip to content

Commit c8db96e

Browse files
committed
Add test_namedtuple to unittests. Missed a merge conflict during rebase. fixes it.
1 parent e97ed86 commit c8db96e

File tree

2 files changed

+186
-6
lines changed

2 files changed

+186
-6
lines changed

src/lib/collections/__init__.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,6 @@ var $builtinmodule = function (name) {
252252

253253

254254
// OrderedDict
255-
<<<<<<< HEAD
256255
mod.OrderedDict = function OrderedDict(items)
257256
{
258257
if (!(this instanceof mod.OrderedDict))
@@ -307,11 +306,6 @@ var $builtinmodule = function (name) {
307306

308307
return Sk.builtin.dict.prototype.mp$ass_subscript.call(this, key, w);
309308
}
310-
=======
311-
mod.OrderedDict = function OrderedDict(items) {
312-
throw new Sk.builtin.NotImplementedError("OrderedDict is not implemented")
313-
};
314-
>>>>>>> can create with a string or tuple now
315309

316310
mod.OrderedDict.prototype.mp$del_subscript = function(key, w)
317311
{

test/unit/test_namedtuple.py

Lines changed: 186 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,186 @@
1+
2+
import unittest, keyword
3+
from collections import namedtuple
4+
5+
TestNT = namedtuple('TestNT', 'x y z') # type used for pickle tests
6+
7+
8+
class TestNamedTuple(unittest.TestCase):
9+
10+
def test_factory(self):
11+
Point = namedtuple('Point', 'x y')
12+
# self.assertEqual(Point.__name__, 'Point')
13+
# self.assertEqual(Point.__slots__, ())
14+
# self.assertEqual(Point.__module__, __name__)
15+
# self.assertEqual(Point.__getitem__, tuple.__getitem__)
16+
# self.assertEqual(Point._fields, ('x', 'y'))
17+
18+
self.assertRaises(ValueError, namedtuple, 'abc%', 'efg ghi') # type has non-alpha char
19+
self.assertRaises(ValueError, namedtuple, 'class', 'efg ghi') # type has keyword
20+
self.assertRaises(ValueError, namedtuple, '9abc', 'efg ghi') # type starts with digit
21+
22+
self.assertRaises(ValueError, namedtuple, 'abc', 'efg g%hi') # field with non-alpha char
23+
self.assertRaises(ValueError, namedtuple, 'abc', 'abc class') # field has keyword
24+
self.assertRaises(ValueError, namedtuple, 'abc', '8efg 9ghi') # field starts with digit
25+
self.assertRaises(ValueError, namedtuple, 'abc', '_efg ghi') # field with leading underscore
26+
self.assertRaises(ValueError, namedtuple, 'abc', 'efg efg ghi') # duplicate field
27+
28+
namedtuple('Point0', 'x1 y2') # Verify that numbers are allowed in names
29+
namedtuple('_', 'a b c') # Test leading underscores in a typename
30+
31+
nt = namedtuple('nt', u'the quick brown fox') # check unicode input
32+
#self.assertNotIn("u'", repr(nt._fields))
33+
nt = namedtuple('nt', (u'the', u'quick')) # check unicode input
34+
#self.assertNotIn("u'", repr(nt._fields))
35+
36+
self.assertRaises(TypeError, Point, [11]) # catch too few args
37+
self.assertRaises(TypeError, Point, [11, 22, 33]) # catch too many args
38+
39+
40+
def test_name_fixer(self):
41+
for spec, renamed in [
42+
[('efg', 'g%hi'), ('efg', '_1')], # field with non-alpha char
43+
[('abc', 'class'), ('abc', '_1')], # field has keyword
44+
[('8efg', '9ghi'), ('_0', '_1')], # field starts with digit
45+
[('abc', '_efg'), ('abc', '_1')], # field with leading underscore
46+
[('abc', 'efg', 'efg', 'ghi'), ('abc', 'efg', '_2', 'ghi')], # duplicate field
47+
[('abc', '', 'x'), ('abc', '_1', 'x')], # fieldname is a space
48+
]:
49+
self.assertEqual(namedtuple('NT', spec, rename=True)._fields, renamed)
50+
51+
def test_instance(self):
52+
Point = namedtuple('Point', 'x y')
53+
p = Point(11, 22)
54+
self.assertEqual(p, Point(x=11, y=22))
55+
self.assertEqual(p, Point(11, y=22))
56+
self.assertEqual(p, Point(y=22, x=11))
57+
self.assertEqual(p, Point(*(11, 22)))
58+
self.assertEqual(p, Point(**dict(x=11, y=22)))
59+
self.assertRaises(TypeError, Point, 1) # too few args
60+
self.assertRaises(TypeError, Point, 1, 2, 3) # too many args
61+
# self.assertRaises(TypeError, eval, 'Point(XXX=1, y=2)', locals()) # wrong keyword argument
62+
# self.assertRaises(TypeError, eval, 'Point(x=1)', locals()) # missing keyword argument
63+
self.assertEqual(repr(p), 'Point(x=11, y=22)')
64+
self.assertNotIn('__weakref__', dir(p))
65+
self.assertEqual(p, Point._make([11, 22])) # test _make classmethod
66+
self.assertEqual(p._fields, ('x', 'y')) # test _fields attribute
67+
self.assertEqual(p._replace(x=1), (1, 22)) # test _replace method
68+
self.assertEqual(p._asdict(), dict(x=11, y=22)) # test _asdict method
69+
self.assertEqual(vars(p), p._asdict()) # verify that vars() works
70+
71+
try:
72+
p._replace(x=1, error=2)
73+
except ValueError:
74+
pass
75+
else:
76+
self._fail('Did not detect an incorrect fieldname')
77+
78+
# verify that field string can have commas
79+
Point = namedtuple('Point', 'x, y')
80+
p = Point(x=11, y=22)
81+
self.assertEqual(repr(p), 'Point(x=11, y=22)')
82+
83+
# verify that fieldspec can be a non-string sequence
84+
Point = namedtuple('Point', ('x', 'y'))
85+
p = Point(x=11, y=22)
86+
self.assertEqual(repr(p), 'Point(x=11, y=22)')
87+
88+
def test_tupleness(self):
89+
Point = namedtuple('Point', 'x y')
90+
p = Point(11, 22)
91+
92+
self.assertIsInstance(p, tuple)
93+
self.assertEqual(p, (11, 22)) # matches a real tuple
94+
self.assertEqual(tuple(p), (11, 22)) # coercable to a real tuple
95+
self.assertEqual(list(p), [11, 22]) # coercable to a list
96+
self.assertEqual(max(p), 22) # iterable
97+
self.assertEqual(max(*p), 22) # star-able
98+
x, y = p
99+
self.assertEqual(p, (x, y)) # unpacks like a tuple
100+
self.assertEqual((p[0], p[1]), (11, 22)) # indexable like a tuple
101+
self.assertRaises(IndexError, p.__getitem__, 3)
102+
103+
self.assertEqual(p.x, x)
104+
self.assertEqual(p.y, y)
105+
# self.assertRaises(AttributeError, eval, 'p.z', locals())
106+
107+
def test_odd_sizes(self):
108+
Zero = namedtuple('Zero', '')
109+
self.assertEqual(Zero(), ())
110+
self.assertEqual(Zero._make([]), ())
111+
self.assertEqual(repr(Zero()), 'Zero()')
112+
self.assertEqual(Zero()._asdict(), {})
113+
self.assertEqual(Zero()._fields, ())
114+
115+
Dot = namedtuple('Dot', 'd')
116+
self.assertEqual(Dot(1), (1,))
117+
self.assertEqual(Dot._make([1]), (1,))
118+
self.assertEqual(Dot(1).d, 1)
119+
self.assertEqual(repr(Dot(1)), 'Dot(d=1)')
120+
self.assertEqual(Dot(1)._asdict(), {'d':1})
121+
self.assertEqual(Dot(1)._replace(d=999), (999,))
122+
self.assertEqual(Dot(1)._fields, ('d',))
123+
124+
n = 5000
125+
import string, random
126+
names = list(set(''.join([random.choice(string.ascii_letters)
127+
for j in range(10)]) for i in range(n)))
128+
n = len(names)
129+
Big = namedtuple('Big', names)
130+
b = Big(*range(n))
131+
self.assertEqual(b, tuple(range(n)))
132+
self.assertEqual(Big._make(range(n)), tuple(range(n)))
133+
for pos, name in enumerate(names):
134+
self.assertEqual(getattr(b, name), pos)
135+
repr(b) # make sure repr() doesn't blow-up
136+
d = b._asdict()
137+
d_expected = dict(zip(names, range(n)))
138+
self.assertEqual(d, d_expected)
139+
b2 = b._replace(**dict([(names[1], 999),(names[-5], 42)]))
140+
b2_expected = range(n)
141+
b2_expected[1] = 999
142+
b2_expected[-5] = 42
143+
self.assertEqual(b2, tuple(b2_expected))
144+
self.assertEqual(b._fields, tuple(names))
145+
146+
147+
def test_name_conflicts(self):
148+
# Some names like "self", "cls", "tuple", "itemgetter", and "property"
149+
# failed when used as field names. Test to make sure these now work.
150+
T = namedtuple('T', 'itemgetter property self cls tuple')
151+
t = T(1, 2, 3, 4, 5)
152+
self.assertEqual(t, (1,2,3,4,5))
153+
newt = t._replace(itemgetter=10, property=20, self=30, cls=40, tuple=50)
154+
self.assertEqual(newt, (10,20,30,40,50))
155+
156+
# Broader test of all interesting names in a template
157+
# with test_support.captured_stdout() as template:
158+
# T = namedtuple('T', 'x', verbose=True)
159+
words = set(re.findall('[A-Za-z]+', template.getvalue()))
160+
words -= set(keyword.kwlist)
161+
T = namedtuple('T', words)
162+
# test __new__
163+
values = tuple(range(len(words)))
164+
t = T(*values)
165+
self.assertEqual(t, values)
166+
t = T(**dict(zip(T._fields, values)))
167+
self.assertEqual(t, values)
168+
# test _make
169+
t = T._make(values)
170+
self.assertEqual(t, values)
171+
# exercise __repr__
172+
repr(t)
173+
# test _asdict
174+
self.assertEqual(t._asdict(), dict(zip(T._fields, values)))
175+
# test _replace
176+
t = T._make(values)
177+
newvalues = tuple(v*10 for v in values)
178+
newt = t._replace(**dict(zip(T._fields, newvalues)))
179+
self.assertEqual(newt, newvalues)
180+
# test _fields
181+
self.assertEqual(T._fields, tuple(words))
182+
# test __getnewargs__
183+
self.assertEqual(t.__getnewargs__(), values)
184+
185+
if __name__ == "__main__":
186+
unittest.main(verbose=True)

0 commit comments

Comments
 (0)