Skip to content

Commit d1e922b

Browse files
committed
fix(compartment-mapper): remove commented notes section from bundle runtime
1 parent a261746 commit d1e922b

File tree

1 file changed

+0
-60
lines changed

1 file changed

+0
-60
lines changed

packages/compartment-mapper/src/bundle-runtime.js

-60
Original file line numberDiff line numberDiff line change
@@ -102,63 +102,3 @@ export function loadApplication(
102102
return { execute, compartments };
103103
}
104104

105-
/*
106-
107-
NOTES
108-
109-
110-
// we want to approximately create an archive compartmentMap with functors
111-
// and then link the compartmentMap into an application via a custom importHook that uses getFunctor
112-
113-
// link turns a compartmentMap (CompartmentDescriptors) into an application (Compartments)
114-
// - actual module sources are loaded via `get`
115-
// -> get could be replaced with getFunctor <----------------------
116-
// - makeArchiveImportHookMaker/importHook creates the records via the parser and `get` and `compartmentMap`
117-
// -> can call getFunctor and put it on the record
118-
// - parser creates a functor via compartment.evaluate
119-
// -> could provide custom compartments that when evaluate is called refer to a precompile
120-
// -> parser could pull module functor off of compartment
121-
122-
// can make an alternate parser for language that pulls the functors out from somewhere
123-
124-
125-
application.execute
126-
ses/src/compartment-shim import
127-
ses/src/module-load load
128-
memoizedLoadWithErrorAnnotation
129-
loadWithoutErrorAnnotation
130-
importHook (via makeArchiveImportHookMaker) returns { record, specifier: moduleSpecifier } as staticModuleRecord
131-
parse (via parserForLanguage) returns { record }
132-
loadRecord assumes record is an alias, returns moduleRecord wrapping record
133-
compartmentImportNow
134-
ses/src/module-link link()
135-
ses/src/module-link instantiate()
136-
if(isPrecompiled)
137-
makeModuleInstance <-- COULD call our functor
138-
compartmentEvaluate
139-
else
140-
makeThirdPartyModuleInstance
141-
staticModuleRecord.execute <-- calls our execute
142-
143-
144-
moduleRecord <- from loadRecord
145-
staticModuleRecord <- from importHook
146-
record <- from parserForLanguage[language].parse
147-
148-
if(isPrecompiled)
149-
makeModuleInstance
150-
sets execute: __syncModuleFunctor__
151-
else
152-
makeThirdPartyModuleInstance
153-
sets execute: staticModuleRecord.execute
154-
execute (via parserForLanguage) from parse-pre-cjs.js
155-
156-
>>>>>>>>> questions
157-
158-
import-archive always invokes module record aliases - is this intentional?
159-
160-
makeModuleInstance + makeThirdPartyModuleInstance
161-
dont rhyme as much as I'd like
162-
163-
164-
*/

0 commit comments

Comments
 (0)