Skip to content

Commit 8603663

Browse files
author
Muhammad Ahmad
committed
refactor(install-engines.sh): Updated readme and refactored to install-engines.sh to run chmod command without any condition
1 parent b333800 commit 8603663

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

packages/benchmark/README.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,4 @@ This package just provides a minimalistic ava-like interface to run benchmark te
66
Run the command `yarn test` in the `packages/benchmark` folder.
77

88
## Pre-reqs of running `yarn test`
9-
Run the command `yarn install-engines` in the `packages/benchmark` folder. This command will install the `eshost` and `esvu`.
10-
* `esvu` is used to insall the binaries of `v8` and `xs` engines
11-
* `eshost` is used to configure the binaries of engines
9+
Run the command `yarn install-engines` to ensure installation of V8 and XS engines in $HOME/.esvu for this package's `eshost`.

packages/benchmark/install-engines.sh

+2-8
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,8 @@ if [ -n "$INSTALL_STATUS_XS" ] || [ -n "$INSTALL_STATUS_V8" ]; then
2929
fi
3030

3131

32-
## Making engine binaries executable (if not already) ##
33-
if [ ! -x "$HOME/.esvu/bin/xs" ]; then
34-
chmod +x "$HOME/.esvu/bin/xs"
35-
fi
36-
37-
if [ ! -x "$HOME/.esvu/bin/v8" ]; then
38-
chmod +x "$HOME/.esvu/bin/v8"
39-
fi
32+
## Making engine binaries executable ##
33+
chmod +x "$HOME/.esvu/bin/xs" "$HOME/.esvu/bin/v8"
4034

4135

4236
## Adding engines to eshost (if not already) ##

0 commit comments

Comments
 (0)