Skip to content

Commit a74086c

Browse files
authored
Queue free pin container when not used
1 parent 2670101 commit a74086c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

addons/block_code/ui/blocks/block/block.gd

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ var pinned: bool:
5050

5151
pinned = value
5252

53-
if not block_pinned_container:
53+
if pinned:
5454
block_pinned_container = Container.new()
5555
block_pinned_container.mouse_filter = Control.MOUSE_FILTER_IGNORE
5656

@@ -66,6 +66,9 @@ var pinned: bool:
6666
block_pinned_panel.add_child(block_pinned_icon)
6767
block_pinned_container.add_child(block_pinned_panel)
6868
add_child(block_pinned_container)
69+
else:
70+
remove_child(block_pinned_container)
71+
block_pinned_container.queue_free()
6972

7073
block_pinned_container.visible = pinned
7174

addons/block_code/ui/blocks/utilities/drag_drop_area/drag_drop_area.gd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ func _gui_input(event: InputEvent) -> void:
4242
if button_event.button_index == MOUSE_BUTTON_LEFT:
4343
_drag_start_position = event.global_position
4444
else:
45+
if not parent_block:
46+
parent_block = BlockTreeUtil.get_parent_block(self)
47+
4548
if parent_block and parent_block.can_delete:
4649
# Accepts to avoid menu conflicts
4750
accept_event()
4851

49-
if not parent_block:
50-
parent_block = BlockTreeUtil.get_parent_block(self)
51-
5252
# A new right-click menu with items
5353
var _context_menu := PopupMenu.new()
5454
_context_menu.add_icon_item(EditorInterface.get_editor_theme().get_icon("Duplicate", "EditorIcons"), "Duplicate")

0 commit comments

Comments
 (0)