Skip to content

Commit 1f0d701

Browse files
committed
test_category_factory: Free Block nodes
Otherwise the test prints warnings about a pile of orphans. https://phabricator.endlessm.com/T35520
1 parent c5a2171 commit 1f0d701

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

tests/test_category_factory.gd

+11-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@ extends GutTest
22
## Tests for CategoryFactory
33

44

5+
func free_block_list(blocks: Array[Block]):
6+
var block: Block = blocks.pop_back()
7+
while block != null:
8+
block.free()
9+
block = blocks.pop_back()
10+
11+
512
func get_category_names(categories: Array[BlockCategory]) -> Array[String]:
613
var names: Array[String] = []
714
for category in categories:
@@ -11,12 +18,15 @@ func get_category_names(categories: Array[BlockCategory]) -> Array[String]:
1118

1219
func get_class_category_names(_class_name: String) -> Array[String]:
1320
var blocks: Array[Block] = CategoryFactory.get_inherited_blocks(_class_name)
14-
return get_category_names(CategoryFactory.get_categories(blocks))
21+
var names: Array[String] = get_category_names(CategoryFactory.get_categories(blocks))
22+
free_block_list(blocks)
23+
return names
1524

1625

1726
func test_general_category_names():
1827
var blocks: Array[Block] = CategoryFactory.get_general_blocks()
1928
var names: Array[String] = get_category_names(CategoryFactory.get_categories(blocks))
29+
free_block_list(blocks)
2030
assert_eq(
2131
names,
2232
[

0 commit comments

Comments
 (0)