Stale SSL context API in .github/CONTRIBUTING.md proxy example #3797
Unanswered
FanWu-ai
asked this question in
Potential Issue
Replies: 1 comment
Maybe?... We don't have open access pull requests here, so we need a decent way of connecting with contributors beforehand so we can introduce ourselves, and deal with onboarding. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
The development proxy example in
.github/CONTRIBUTING.mdappears to be out of sync with the current API:httpx.SSLContext()is not a public HTTPX API.httpx.Client(..., ssl_context=ssl_context)uses an unsupported keyword;Clientaccepts a customssl.SSLContextthroughverify.The corresponding example in
docs/contributing.mdalready usesssl.create_default_context(cafile=...)andverify=ctx. A small update to the GitHub contribution guide could use the same approach while keeping its context manager:This report is based on inspecting the documentation and
Clientconstructor source; I have not run the proxy setup or tests.Would a small documentation-only PR aligning this example with
docs/contributing.mdbe welcome?All reactions