A bug in how httpx handle auth parameter

[dheerajck]

import httpx

httpx.get('https://www.example.org/', auth=(None, None))

throws this error rn

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[7], line 1
----> 1 httpx.get('https://www.example.org/', auth=(None, None))

File venv/lib/python3.11/site-packages/httpx/_api.py:198, in get(url, params, headers, cookies, auth, proxy, proxies, follow_redirects, cert, verify, timeout, trust_env)
    175 def get(
    176     url: URLTypes,
    177     *,
   (...)
    188     trust_env: bool = True,
    189 ) -> Response:
    190     """
    191     Sends a `GET` request.
    192 
   (...)
    196     on this function, as `GET` requests should not include a request body.
    197     """
--> 198     return request(
    199         "GET",
    200         url,
    201         params=params,
    202         headers=headers,
    203         cookies=cookies,
    204         auth=auth,
    205         proxy=proxy,
    206         proxies=proxies,
    207         follow_redirects=follow_redirects,
    208         cert=cert,
    209         verify=verify,
    210         timeout=timeout,
    211         trust_env=trust_env,
    212     )

File venv/lib/python3.11/site-packages/httpx/_api.py:106, in request(method, url, params, content, data, files, json, headers, cookies, auth, proxy, proxies, timeout, follow_redirects, verify, cert, trust_env)
     46 """
     47 Sends an HTTP request.
     48 
   (...)
     95 ```
     96 """
     97 with Client(
     98     cookies=cookies,
     99     proxy=proxy,
   (...)
    104     trust_env=trust_env,
    105 ) as client:
--> 106     return client.request(
    107         method=method,
    108         url=url,
    109         content=content,
    110         data=data,
    111         files=files,
    112         json=json,
    113         params=params,
    114         headers=headers,
    115         auth=auth,
    116         follow_redirects=follow_redirects,
    117     )

File venv/lib/python3.11/site-packages/httpx/_client.py:827, in Client.request(self, method, url, content, data, files, json, params, headers, cookies, auth, follow_redirects, timeout, extensions)
    812     warnings.warn(message, DeprecationWarning)
    814 request = self.build_request(
    815     method=method,
    816     url=url,
   (...)
    825     extensions=extensions,
    826 )
--> 827 return self.send(request, auth=auth, follow_redirects=follow_redirects)

File venv/lib/python3.11/site-packages/httpx/_client.py:912, in Client.send(self, request, stream, auth, follow_redirects)
    905 self._state = ClientState.OPENED
    906 follow_redirects = (
    907     self.follow_redirects
    908     if isinstance(follow_redirects, UseClientDefault)
    909     else follow_redirects
    910 )
--> 912 auth = self._build_request_auth(request, auth)
    914 response = self._send_handling_auth(
    915     request,
    916     auth=auth,
    917     follow_redirects=follow_redirects,
    918     history=[],
    919 )
    920 try:

File venv/lib/python3.11/site-packages/httpx/_client.py:442, in BaseClient._build_request_auth(self, request, auth)
    436 def _build_request_auth(
    437     self,
    438     request: Request,
    439     auth: AuthTypes | UseClientDefault | None = USE_CLIENT_DEFAULT,
    440 ) -> Auth:
    441     auth = (
--> 442         self._auth if isinstance(auth, UseClientDefault) else self._build_auth(auth)
    443     )
    445     if auth is not None:
    446         return auth

File venv/lib/python3.11/site-packages/httpx/_client.py:428, in BaseClient._build_auth(self, auth)
    426     return None
    427 elif isinstance(auth, tuple):
--> 428     return BasicAuth(username=auth[0], password=auth[1])
    429 elif isinstance(auth, Auth):
    430     return auth

File venv/lib/python3.11/site-packages/httpx/_auth.py:130, in BasicAuth.__init__(self, username, password)
    129 def __init__(self, username: str | bytes, password: str | bytes) -> None:
--> 130     self._auth_header = self._build_auth_header(username, password)

File venv/lib/python3.11/site-packages/httpx/_auth.py:137, in BasicAuth._build_auth_header(self, username, password)
    136 def _build_auth_header(self, username: str | bytes, password: str | bytes) -> str:
--> 137     userpass = b":".join((to_bytes(username), to_bytes(password)))
    138     token = b64encode(userpass).decode()
    139     return f"Basic {token}"

TypeError: sequence item 0: expected a bytes-like object, NoneType found

whereas requests doesnt throw the error rn

import requests


requests.get('https://www.example.org/', auth=(None, None))

I think we should handle this exception and throw a new exception that will let user know they should use auth=None or handle it exactly like how requests do it rn,

I would love to open an issue and a pr to fix this thing.

Thankyou.

[whilenot-dev]

The auth parameter is typed like the following:

AuthTypes = Union[
    Tuple[Union[str, bytes], Union[str, bytes]],
    Callable[["Request"], "Request"],
    "Auth",
]

So according to the types (None, None) is not valid anyway.