Tests fail due to capitalization of Transfer-Encoding response header

[achille-roussel]

Hello!

I did a fresh checkout of the repository on OSX with Python 3.11.7 installed and got the following error when running the tests:

_________________________________________________________________________________________________________________________________________________________ test_auth __________________________________________________________________________________________________________________________________________________________

server = <tests.conftest.TestServer object at 0x105bc2810>

    def test_auth(server):
        url = str(server.url)
        runner = CliRunner()
        result = runner.invoke(httpx.main, [url, "-v", "--auth", "username", "password"])
        print(result.output)
        assert result.exit_code == 0
>       assert remove_date_header(splitlines(result.output)) == [
            "* Connecting to '127.0.0.1'",
            "* Connected to '127.0.0.1' on port 8000",
            "GET / HTTP/1.1",
            f"Host: {server.url.netloc.decode('ascii')}",
            "Accept: */*",
            "Accept-Encoding: gzip, deflate, br",
            "Connection: keep-alive",
            f"User-Agent: python-httpx/{httpx.__version__}",
            "Authorization: Basic dXNlcm5hbWU6cGFzc3dvcmQ=",
            "",
            "HTTP/1.1 200 OK",
            "server: uvicorn",
            "content-type: text/plain",
            "Transfer-Encoding: chunked",
            "",
            "Hello, world!",
        ]
E       assert ["* Connectin...ate, br', ...] == ["* Connectin...ate, br', ...]
E
E         At index 13 diff: 'transfer-encoding: chunked' != 'Transfer-Encoding: chunked'
E         Use -v to get more diff

tests/test_main.py:151: AssertionError
---------------------------------------------------------------------------------------------------------------------------------------------------- Captured stdout call ----------------------------------------------------------------------------------------------------------------------------------------------------
INFO:     127.0.0.1:62749 - "GET / HTTP/1.1" 200 OK
* Connecting to '127.0.0.1'
* Connected to '127.0.0.1' on port 8000
GET / HTTP/1.1
Host: 127.0.0.1:8000
Accept: */*
Accept-Encoding: gzip, deflate, br
Connection: keep-alive
User-Agent: python-httpx/0.26.0
Authorization: Basic dXNlcm5hbWU6cGFzc3dvcmQ=

HTTP/1.1 200 OK
date: Wed, 21 Feb 2024 17:32:26 GMT
server: uvicorn
content-type: text/plain
transfer-encoding: chunked

Hello, world!

All tests in test_main.py that have a Transfer-Encoding header are failing.

Changing the header name to lowercase transfer-encoding seems to address the issue.

Let me know if you this is worthy of a fix, I can send a pull request.

[karpetrosyan]

Hi! Can you please share your pip freeze output so we can figure out where the problem comes from?

[achille-roussel]

Here you go:

annotated-types==0.6.0
anyio==4.2.0
async-generator==1.10
attrs==23.2.0
auditwheel==6.0.0
Babel==2.14.0
black==24.1.0
Brotli==1.1.0
build==1.0.3
cachetools==5.3.2
certifi==2023.11.17
chardet==5.2.0
charset-normalizer==3.3.2
click==8.1.7
colorama==0.4.6
coverage==7.4.1
cryptography==42.0.2
distlib==0.3.8
dnspython==2.5.0
email-validator==2.1.0.post1
fastapi==0.109.0
filelock==3.13.1
ghp-import==2.1.0
greenlet==3.0.3
grpc-stubs==1.53.0.5
grpcio==1.60.0
h11==0.14.0
h2==4.1.0
hpack==4.0.0
http-message-signatures==0.4.4
http_sfv==0.9.9
httpcore==1.0.2
httptools==0.6.1
hyperframe==6.0.1
idna==3.6
importlib-metadata==7.0.1
iniconfig==2.0.0
isort==5.13.2
itsdangerous==2.1.2
jaraco.classes==3.3.1
Jinja2==3.1.3
jsonpickle==3.0.2
keyring==24.3.0
Markdown==3.5.2
markdown-it-py==3.0.0
MarkupSafe==2.1.5
mdurl==0.1.2
mergedeep==1.3.4
mkautodoc==0.2.0
mkdocs==1.5.3
mkdocs-material==9.5.6
mkdocs-material-extensions==1.3.1
more-itertools==10.2.0
mypy==1.8.0
mypy-extensions==1.0.0
nh3==0.2.15
orjson==3.9.13
outcome==1.3.0.post0
packaging==23.2
paginate==0.5.6
pathspec==0.12.1
pkginfo==1.9.6
platformdirs==4.2.0
pluggy==1.4.0
protobuf==4.24.0
pydantic==2.6.1
pydantic-extra-types==2.5.0
pydantic-settings==2.1.0
pydantic_core==2.16.2
pyelftools==0.30
Pygments==2.17.2
pymdown-extensions==10.7
pyproject-api==1.6.1
pyproject_hooks==1.0.0
pytest==8.0.0
python-dateutil==2.8.2
python-dotenv==1.0.1
python-multipart==0.0.7
pyyaml_env_tag==0.1
readme-renderer==42.0
regex==2023.12.25
requests==2.31.0
requests-toolbelt==1.0.0
rfc3986==2.0.0
rich==13.7.0
ruff==0.1.15
setuptools-git-versioning==1.13.6
six==1.16.0
sniffio==1.3.0
socksio==1.0.0
sortedcontainers==2.4.0
starlette==0.35.1
tblib==3.0.0
tox==4.13.0
trio==0.24.0
trio-typing==0.10.0
trustme==1.1.0
twine==4.0.2
types-docutils==0.20.0.20240201
types-protobuf==4.24.0.20240129
types-Pygments==2.17.0.20240106
types-requests==2.31.0.20240125
types-setuptools==69.0.0.20240125
types-six==1.16.21.20240106
typing_extensions==4.9.0
ujson==5.9.0
urllib3==2.1.0
uvicorn==0.27.0.post1
uvloop==0.19.0
virtualenv==20.25.0
watchdog==4.0.0
watchfiles==0.21.0
websockets==12.0
zipp==3.17.0

[nieder]

Also seeing this with httpx-0.28.1 on macOS and python3.10.

nieder $ pip-py3.10 freeze
a2wsgi==1.10.8
anyio==0.0.0
asn1crypto==1.5.1
attrs==23.2.0
Beaker==1.11.0
Brotli==1.1.0
certifi==2023.7.22
cffi==1.17.1
chardet==5.2.0
charset-normalizer==3.3.2
click==8.1.7
coverage==7.6.1
cryptography==3.3.2
decorator==5.1.1
editables==0.5
elementpath==4.6.0
exceptiongroup==1.2.0
execnet==2.0.2
Flask==2.2.5
flit_core==3.9.0
gevent==24.2.1
greenlet==3.1.1
h11==0.14.0
h2==4.1.0
hatch-fancy-pypi-readme==24.1.0
hatchling==1.25.0
hpack==4.0.0
httpbin==0.10.0
httpcore==1.0.7
httptools==0.6.4
httpx==0.28.1
hyperframe==6.0.1
hypothesis==6.42.1
idna==3.6
importlib-metadata==7.0.1
iniconfig==2.0.0
invoke==1.2.0
itsdangerous==2.1.2
Jinja2==3.1.3
MarkupSafe==2.1.5
more-itertools==7.2.0
outcome==1.3.0
packaging==24.1
pathspec==0.12.1
pdm-backend==2.4.3
pluggy==1.4.0
poetry-core==1.9.0
py==1.11.0
pyaml==23.12.0
pyasn1==0.4.7
pycparser==2.21
Pygments==2.18.0
pyOpenSSL==22.0.0
pyparsing==3.1.4
pytest==7.4.4
pytest-asyncio==0.21.1
pytest-cov==6.0.0
pytest-httpbin==2.0.0
pytest-mock==3.12.0
pytest-trio==0.8.0
pytest-xdist==3.5.0
python-dotenv==1.0.1
PyYAML==6.0.1
rich==13.7.0
SCons==4.4.0
setuptools-scm==7.1.0
sh==2.0.6
six==1.16.0
sniffio==1.3.0
socksio==1.0.0
sortedcontainers==2.4.0
toml==0.10.2
tomli==2.0.1
trio==0.22.2
trove-classifiers==0.0.0
trustme==1.2.0
typing_extensions==4.7.1
Unidecode==1.3.8
urllib3==1.26.16
uvicorn==0.33.0
wcwidth==0.1.7
websockets==10.4
Werkzeug==3.0.1
wsproto==1.2.0
zipp==0.0.0
zope.event==4.5.0
zope.interface==5.4.0
zstandard==0.23.0