Event hooks and raise_for_status

[daviddavis]

I'm using an example from the docs to raise_for_status automatically using event_hooks.

I would expect these two examples to work:

import httpx

try:
    resp = httpx.get("http://httpbin.org/status/400")
    resp.raise_for_status()
except httpx.HTTPStatusError as e:
    print(f"Body: {e.response.text}")

import httpx

def raise_on_4xx_5xx(response):
    response.raise_for_status()

client = httpx.Client(event_hooks={'response': [raise_on_4xx_5xx]})

try:
    resp = client.get("http://httpbin.org/status/400")
except httpx.HTTPStatusError as e:
    print(f"Body: {e.response.text}"). # httpx.ResponseNotRead

But the second one doesn't work. It raises a httpx.ResponseNotRead and when I try to call read() on the response, I get httpx.StreamClosed.

Anyone know how I can get this working so I can read the response content?

[daviddavis]

It looks like if I call read() in raise_on_4xx_5xx then things work as expected (no exception):

import httpx

def raise_on_4xx_5xx(response):
    response.read()
    response.raise_for_status()

client = httpx.Client(event_hooks={'response': [raise_on_4xx_5xx]})

try:
    resp = client.get("http://httpbin.org/status/400")
except httpx.HTTPStatusError as e:
    print(f"Body: {e.response.text}"). # httpx.ResponseNotRead

I'm guessing that raise_for_status closes the response so it's necessary to call read before raise_for_status.