Proxy errors

[povilasb]

I have this one case where httpx yields me ConnectError where I think ProxyError should be raised.

Consider this snippet I tested with httpx == 0.22.0:

    async with AsyncClient(proxies="http://localhost:8082") as http:
        resp = await http.get("https://httpbin.org/ip")
        print(resp.json())

Note that there is no HTTP proxy listening on 8082 port.

This code results in

anyio._backends._asyncio.ExceptionGroup: 2 exceptions were raised in the task group:
----------------------------
Traceback (most recent call last):
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/anyio/_core/_sockets.py", line 127, in try_connect
    stream = await asynclib.connect_tcp(remote_host, remote_port, local_address)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 1518, in connect_tcp
    await get_running_loop().create_connection(StreamProtocol, host, port,
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/base_events.py", line 1055, in create_connection
    raise exceptions[0]
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/base_events.py", line 1040, in create_connection
    sock = await self._connect_sock(
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/base_events.py", line 954, in _connect_sock
    await self.sock_connect(sock, address)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/selector_events.py", line 502, in sock_connect
    return await fut
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/selector_events.py", line 537, in _sock_connect_cb
    raise OSError(err, f'Connect call failed {address}')
ConnectionRefusedError: [Errno 61] Connect call failed ('::1', 8082, 0, 0)
----------------------------
Traceback (most recent call last):
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/anyio/_core/_sockets.py", line 127, in try_connect
    stream = await asynclib.connect_tcp(remote_host, remote_port, local_address)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 1518, in connect_tcp
    await get_running_loop().create_connection(StreamProtocol, host, port,
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/base_events.py", line 1055, in create_connection
    raise exceptions[0]
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/base_events.py", line 1040, in create_connection
    sock = await self._connect_sock(
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/base_events.py", line 954, in _connect_sock
    await self.sock_connect(sock, address)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/selector_events.py", line 502, in sock_connect
    return await fut
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/selector_events.py", line 537, in _sock_connect_cb
    raise OSError(err, f'Connect call failed {address}')
ConnectionRefusedError: [Errno 61] Connect call failed ('127.0.0.1', 8082)


The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/_exceptions.py", line 8, in map_exceptions
    yield
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/backends/asyncio.py", line 101, in connect_tcp
    stream: anyio.abc.ByteStream = await anyio.connect_tcp(
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/anyio/_core/_sockets.py", line 184, in connect_tcp
    raise OSError('All connection attempts failed') from cause
OSError: All connection attempts failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_transports/default.py", line 60, in map_httpcore_exceptions
    yield
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_transports/default.py", line 353, in handle_async_request
    resp = await self._pool.handle_async_request(req)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 253, in handle_async_request
    raise exc
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 237, in handle_async_request
    response = await connection.handle_async_request(request)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/_async/http_proxy.py", line 255, in handle_async_request
    connect_response = await self._connection.handle_async_request(
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/_async/connection.py", line 86, in handle_async_request
    raise exc
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/_async/connection.py", line 63, in handle_async_request
    stream = await self._connect(request)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/_async/connection.py", line 111, in _connect
    stream = await self._network_backend.connect_tcp(**kwargs)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/backends/auto.py", line 23, in connect_tcp
    return await self._backend.connect_tcp(
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/backends/asyncio.py", line 99, in connect_tcp
    with map_exceptions(exc_map):
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/contextlib.py", line 153, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpcore/_exceptions.py", line 12, in map_exceptions
    raise to_exc(exc)
httpcore.ConnectError: All connection attempts failed

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/private/tmp/main.py", line 11, in <module>
    asyncio.run(main())
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/asyncio/base_events.py", line 641, in run_until_complete
    return future.result()
  File "/private/tmp/main.py", line 7, in main
    resp = await http.get("https://httpbin.org/ip")
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_client.py", line 1729, in get
    return await self.request(
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_client.py", line 1506, in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_client.py", line 1593, in send
    response = await self._send_handling_auth(
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_client.py", line 1621, in _send_handling_auth
    response = await self._send_handling_redirects(
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_client.py", line 1658, in _send_handling_redirects
    response = await self._send_single_request(request)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_client.py", line 1695, in _send_single_request
    response = await transport.handle_async_request(request)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_transports/default.py", line 352, in handle_async_request
    with map_httpcore_exceptions():
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/contextlib.py", line 153, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/Users/povilas/.pyenv/versions/3.10.1/lib/python3.10/site-packages/httpx/_transports/default.py", line 77, in map_httpcore_exceptions
    raise mapped_exc(message) from exc
httpx.ConnectError: All connection attempts failed

But given that we know that connection with the proxy server failed, I believe httpx should raise ProxyError instead?

What do you think? :)