AsyncByteStream change

[ahopkins]

TypeError: AsyncByteStream.aread() takes 1 positional argument but 2 were given

Our CI starting failing because of this. I did not see any notice of changes related to byte streams. What is the accepted usage now? Is there a backwards compatible solution?

data = ["hello", "world"]

class Data(AsyncByteStream):
    def __init__(self):
        self.data = data

    async def __aiter__(self):
        for value in self.data:
            yield value.encode("utf-8")

client = ReusableClient(app, port=1234)

with client:
    _, response1 = client.post("/", data=Data(data))
    _, response2 = client.post("/", data=Data(data))

[ahopkins]

Tests changed to:

async def stream(data):
    for value in data:
        yield value.encode("utf-8")

with client:
    _, response1 = client.post("/", data=stream(data))
    _, response2 = client.post("/", data=stream(data))

[lovelydinosaur]

Thanks for raising this. Confirmed yes.
Looks to me like an unintended side effect of #1948

[ahopkins]

Thanks @tomchristie.

Not sure if that was meant as an intended usage of the API or not.

[lovelydinosaur]

Resolved via #2016

[lovelydinosaur]

Released as 0.21.3

[ahopkins]

Thanks for the heads up and fast release.