Possibly infinite redirects to the same url

[dekked]

Hello,

I am running this simple script:

import asyncio
import httpx

async def main():
    async with httpx.AsyncClient() as client:
        resp = await client.head("https://www.footlocker.com/product/~/EV7566.html")
        print(resp.history, resp.status_code)


event_loop = asyncio.get_event_loop()
event_loop.run_until_complete(main())

Which results in the following traceback:

    return future.result()
  File "minimal.py", line 6, in main
    resp = await client.head("https://www.footlocker.com/product/~/EV7566.html")
  File "/home/user/.pyenv/versions/redirects/lib/python3.8/site-packages/httpx/_client.py", line 1593, in head
    return await self.request(
  File "/home/user/.pyenv/versions/redirects/lib/python3.8/site-packages/httpx/_client.py", line 1361, in request
    response = await self.send(
  File "/home/user/.pyenv/versions/redirects/lib/python3.8/site-packages/httpx/_client.py", line 1396, in send
    response = await self._send_handling_auth(
  File "/home/user/.pyenv/versions/redirects/lib/python3.8/site-packages/httpx/_client.py", line 1434, in _send_handling_auth
    response = await self._send_handling_redirects(
  File "/home/user/.pyenv/versions/redirects/lib/python3.8/site-packages/httpx/_client.py", line 1462, in _send_handling_redirects
    raise TooManyRedirects(
httpx.TooManyRedirects: Exceeded maximum allowed redirects.

According to httpx, the site is generating a chain of 301 Redirects, all to the same URL.

However, the same doesn't happen with httpie (or requests):

> http HEAD https://www.footlocker.com/product/\~/EV7566.html

HTTP/1.1 200 OK
Accept-Ranges: bytes
Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept
Access-Control-Allow-Origin: *
Age: 0
Connection: keep-alive
Content-Encoding: gzip
Content-Length: 46652
Content-Type: text/html; charset=utf-8
Date: Sat, 27 Mar 2021 03:26:38 GMT
ETag: W/"2e00e-SN+FTmB6Tq3DUWjWMTETxxO2vqI"
Server: nginx
Strict-Transport-Security: max-age=31557600
Vary: Accept-Encoding
X-Cache: MISS, MISS
X-FL-QIT-DEBUG: start
X-Powered-By: Express
X-Served-By: cache-bwi5128-BWI, cache-eze19323-EZE
X-Timer: S1616815598.355988,VS0,VE308
locid: 573fea20-659c-4221-8ef3-6e5e89484270-sta
srvid: M136.70

I tried setting cookies, deleting cookies, and even changing headers. I am pretty sure it's not the site that is acting weirdly (I could be wrong, though).

The versions:

• Python 3.8.2
• httpcore==0.12.3
• httpx==0.17.1

[j178]

Hi, I think this is a same issue as #1517, it should be fixed by the unreleased rfc3986 version.

[dekked]

Indeed!

Thanks for the reference, hope they can get this released to PyPI soon.