Skip to content

Commit b7d3b30

Browse files
authored
Remove some unneeded testing (#20787)
Add a new @only_wasm2js decoration for tests that test basic codegen that makes sense to do only in wasm2js (as for the wasm backend in general we assume basic codegen is tested in LLVM; we could do the same for wasm2js which is in Binaryen, but I think some of the Emscripten tests are a good complement to there).
1 parent b432152 commit b7d3b30

File tree

4 files changed

+9
-43
lines changed

4 files changed

+9
-43
lines changed

.circleci/config.yml

-1
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,6 @@ jobs:
558558
core2s.test_module_wasm_memory
559559
wasm2js3.test_memorygrowth_2
560560
wasmfs.test_hello_world
561-
wasmfs.test_hello_world_standalone
562561
wasmfs.test_unistd_links*
563562
wasmfs.test_atexit_standalone
564563
wasmfs.test_emscripten_get_now

test/core/test_sintvars.c

-31
This file was deleted.

test/core/test_sintvars.out

-4
This file was deleted.

test/test_core.py

+9-7
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,14 @@ def decorated(f):
134134
return decorated
135135

136136

137+
def only_wasm2js(note=''):
138+
assert not callable(note)
139+
140+
def decorated(f):
141+
return skip_if(f, 'is_wasm2js', note, negate=True)
142+
return decorated
143+
144+
137145
def also_with_noderawfs(func):
138146
assert callable(func)
139147

@@ -406,8 +414,6 @@ def get_bullet_library(self, use_cmake):
406414
configure_args=configure_args,
407415
cache_name_extra=configure_commands[0])
408416

409-
@also_with_standalone_wasm()
410-
@also_with_wasmfs
411417
def test_hello_world(self):
412418
self.do_core_test('test_hello_world.c')
413419

@@ -426,14 +432,10 @@ def test_hello_argc_pthreads(self):
426432
self.set_setting('EXIT_RUNTIME')
427433
self.do_core_test('test_hello_argc.c', args=['hello', 'world'])
428434

429-
@also_with_wasmfs
435+
@only_wasm2js('test shifts etc. on 64-bit integers')
430436
def test_intvars(self):
431437
self.do_core_test('test_intvars.cpp')
432438

433-
@also_with_wasmfs
434-
def test_sintvars(self):
435-
self.do_core_test('test_sintvars.c')
436-
437439
def test_int53(self):
438440
if common.EMTEST_REBASELINE:
439441
self.run_process([EMCC, test_file('core/test_int53.c'), '-o', 'a.js', '-DGENERATE_ANSWERS'] + self.emcc_args)

0 commit comments

Comments
 (0)