Skip to content

Commit b2c9a15

Browse files
authored
Improve other.test_legalize_js_ffi - remove comments and whitespace in a cleaner, more general manner. this will avoid the test breaking for minor wasm text format changes, like extra comments (#6874)
1 parent 9d8c596 commit b2c9a15

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

tests/test_other.py

+8-5
Original file line numberDiff line numberDiff line change
@@ -8134,15 +8134,18 @@ def test_legalize_js_ffi(self):
81348134
output, err = proc.communicate()
81358135
assert proc.returncode == 0
81368136
text = open('a.out.wast').read()
8137-
#print "text: %s" % text
8138-
e_add_f32 = re.search('func \$_add_f \(; \d+ ;\) \(param \$*. f32\) \(param \$*. f32\) \(result f32\)', text)
8137+
# remove internal comments and extra whitespace
8138+
text = re.sub(r'\(;[^;]+;\)', '', text)
8139+
text = re.sub(r' +', ' ', text)
8140+
#print("text: %s" % text)
8141+
e_add_f32 = re.search('func \$_add_f \(param \$*. f32\) \(param \$*. f32\) \(result f32\)', text)
81398142
i_i64_i32 = re.search('import .*"_import_ll" .*\(param i32 i32\) \(result i32\)', text)
81408143
i_f32_f64 = re.search('import .*"_import_f" .*\(param f64\) \(result f64\)', text)
81418144
i_i64_i64 = re.search('import .*"_import_ll" .*\(param i64\) \(result i64\)', text)
81428145
i_f32_f32 = re.search('import .*"_import_f" .*\(param f32\) \(result f32\)', text)
8143-
e_i64_i32 = re.search('func \$_add_ll \(; \d+ ;\) \(param \$*. i32\) \(param \$*. i32\) \(param \$*. i32\) \(param \$*. i32\) \(result i32\)', text)
8144-
e_f32_f64 = re.search('func \$legalstub\$_add_f \(; \d+ ;\) \(param \$*. f64\) \(param \$*. f64\) \(result f64\)', text)
8145-
e_i64_i64 = re.search('func \$_add_ll \(; \d+ ;\) \(param \$*. i64\) \(param \$*. i64\) \(result i64\)', text)
8146+
e_i64_i32 = re.search('func \$_add_ll \(param \$*. i32\) \(param \$*. i32\) \(param \$*. i32\) \(param \$*. i32\) \(result i32\)', text)
8147+
e_f32_f64 = re.search('func \$legalstub\$_add_f \(param \$*. f64\) \(param \$*. f64\) \(result f64\)', text)
8148+
e_i64_i64 = re.search('func \$_add_ll \(param \$*. i64\) \(param \$*. i64\) \(result i64\)', text)
81468149
#print e_add_f32, i_i64_i32, i_f32_f64, i_i64_i64, i_f32_f32, e_i64_i32, e_f32_f64, e_i64_i64
81478150
assert e_add_f32, 'add_f export missing'
81488151
if js_ffi:

0 commit comments

Comments
 (0)