Skip to content

Commit 8778c72

Browse files
authored
Remove unneeded d8 flag used in testing. NFC (#18836)
This issue has been marked as fixed for many years now.
1 parent 4851d85 commit 8778c72

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

test/jsrun.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ def make_command(filename, engine, args=None):
3939
is_jsc = 'jsc' in jsengine
4040
is_wasmer = 'wasmer' in jsengine
4141
is_wasmtime = 'wasmtime' in jsengine
42-
# Disable true async compilation (async apis will in fact be synchronous) for now
43-
# due to https://bugs.chromium.org/p/v8/issues/detail?id=6263
44-
shell_option_flags = ['--no-wasm-async-compilation'] if is_d8 else []
4542
command_flags = []
4643
if is_wasmer:
4744
command_flags += ['run']
@@ -50,7 +47,7 @@ def make_command(filename, engine, args=None):
5047
filename = shared.replace_suffix(filename, '.wasm')
5148
# Separates engine flags from script flags
5249
flag_separator = ['--'] if is_d8 or is_jsc else []
53-
return engine + command_flags + [filename] + shell_option_flags + flag_separator + args
50+
return engine + command_flags + [filename] + flag_separator + args
5451

5552

5653
def check_engine(engine):

0 commit comments

Comments
 (0)