Only rename closure inputs if needed (#14937)

We rename the files we pass to closure in order to work around
google/closure-compiler#3784.

However when we do this it makes debugging difficult because the
error messages contains temp files rather than actual input files.

So, only do the renaming if actually needed.

Author: sbc100

tools/building.py

@@ -752,6 +752,17 @@ def check_closure_compiler(cmd, args, env, allowed_to_fail):
   return True
 
 
+# Remove this once we require python3.7 and can use std.isascii.
+# See: https://docs.python.org/3/library/stdtypes.html#str.isascii
+def isascii(s):
+  try:
+    s.encode('ascii')
+  except UnicodeEncodeError:
+    return False
+  else:
+    return True
+
+
 @ToolchainProfiler.profile_block('closure_compiler')
 def closure_compiler(filename, pretty, advanced=True, extra_closure_args=None):
   env = shared.env_with_node_in_path()
@@ -842,6 +853,8 @@ def add_to_path(dirname):
   outfile = tempfiles.get('.cc.js').name  # Safe 7-bit filename
 
   def move_to_safe_7bit_ascii_filename(filename):
+    if isascii(filename):
+      return filename
     safe_filename = tempfiles.get('.js').name  # Safe 7-bit filename
     shutil.copyfile(filename, safe_filename)
     return os.path.relpath(safe_filename, tempfiles.tmpdir)