Skip to content

Commit 1c7c271

Browse files
authored
Add a browser64_4gb mode and run a few tests in that mode. NFC (#20763)
This matches the wasm64_4gb mode which runs the tests with all data offset such that it lives above 4gb.
1 parent 990b754 commit 1c7c271

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

.circleci/config.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,13 @@ jobs:
792792
steps:
793793
- run-tests-chrome:
794794
title: "browser64"
795-
test_targets: "browser64 skip:browser64.test_4gb_fail"
795+
# skip test_4gb_fail as it OOMs on the current bot
796+
# Run a few tests in browser64_4gb mode too.
797+
test_targets: "
798+
browser64
799+
skip:browser64.test_4gb_fail
800+
browser64_4gb.test_emscripten_log
801+
"
796802
test-browser-firefox:
797803
executor: bionic
798804
steps:

test/runner.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@
9696
'wasm64l',
9797
'bigint',
9898
'browser64',
99+
'browser64_4gb',
99100
]
100101

101102

test/test_browser.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5887,3 +5887,13 @@ def setUp(self):
58875887
self.set_setting('MEMORY64')
58885888
self.emcc_args.append('-Wno-experimental')
58895889
self.require_wasm64()
5890+
5891+
5892+
class browser64_4gb(browser):
5893+
def setUp(self):
5894+
super().setUp()
5895+
self.set_setting('MEMORY64')
5896+
self.set_setting('INITIAL_MEMORY', '4200mb')
5897+
self.set_setting('GLOBAL_BASE', '4gb')
5898+
self.emcc_args.append('-Wno-experimental')
5899+
self.require_wasm64()

0 commit comments

Comments
 (0)