Refactor Plot::show_dyn internals (#161)

Closes #166

`show_dyn` is a massive function with non-trivial dependencies. 

This PR attempts to untangle it and make it easier to navigate and
understand.

# Public API changes:

- simplified `show` lifetime

Removed items from the public API
---------------------------------
```
-pub fn egui_plot::Plot<'a>::show<'b, R>(self, ui: &mut egui::ui::Ui, build_fn: impl core::ops::function::FnOnce(&mut egui_plot::PlotUi<'b>) -> R + 'a) -> egui_plot::PlotResponse<R>
```
Added items to the public API
---------------------------------
```
+pub fn egui_plot::Plot<'a>::show<R>(self, ui: &mut egui::ui::Ui, build_fn: impl core::ops::function::FnOnce(&mut egui_plot::PlotUi<'a>) -> R + 'a) -> egui_plot::PlotResponse<R>
```

Author: michalsustr

Makefile

@@ -188,8 +188,8 @@ check_branch_name:
 
 check_todos_have_issues:
 	# The code should not have TODOs without issue tracking. Format that must be followed is:
-	# TODO #<issue_number>: <description>
-	git ls-files | grep -P '\.rs$$' | xargs grep -Pi 'TODO(?! #\d+: \w+)' || exit 0; exit 1
+	# TODO(#<issue_number>): <description>
+	git ls-files | grep -P '\.rs$$' | xargs grep -Pi 'TODO(?!\(#\d+\): \w+)' || exit 0; exit 1
 
 check_no_fixme:
 	# The code should not have FIXME comments

demo/src/app.rs

@@ -28,7 +28,7 @@ impl eframe::App for DemoGallery {
 
 impl DemoGallery {
     // Width of a column in the thumbnails panel.
-    // TODO #193: I don't know what units this corresponds to, and should be
+    // TODO(#193): I don't know what units this corresponds to, and should be
     // cleaned up.
     const COL_WIDTH: f32 = 128.0;
 
@@ -89,7 +89,7 @@ impl DemoGallery {
             // Set min_width so the heading is well rendered.
             .min_width(100.0)
             // 3 columns + some space extra for buttons.
-            // TODO #193: get rid of "extra space" calc.
+            // TODO(#193): get rid of "extra space" calc.
             .max_width(Self::COL_WIDTH * 3. + 30.)
             .resizable(true)
             .show(ctx, |ui| {
@@ -191,7 +191,7 @@ impl DemoGallery {
 
         let button = {
             let texture = &self.thumbnail_textures[index];
-            // TODO #193: I don't know what units this corresponds to, and should be
+            // TODO(#193): I don't know what units this corresponds to, and should be
             // cleaned up.
             let image = egui::Image::new((texture.id(), Vec2::splat(110.0 * scale)));
             let mut button = egui::Button::image(image);

egui_plot/src/axis.rs

@@ -362,7 +362,7 @@ impl<'a> AxisWidget<'a> {
 
                         match HPlacement::from(self.hints.placement) {
                             HPlacement::Left => {
-                                let angle = 0.0; // TODO #162: allow users to rotate text
+                                let angle = 0.0; // TODO(#162): allow users to rotate text
 
                                 if angle == 0.0 {
                                     let x = self.rect.max.x - galley_size.x + SIDE_MARGIN;

egui_plot/src/items/mod.rs

@@ -1,5 +1,5 @@
 //! Contains items that can be added to a plot.
-#![expect(clippy::type_complexity)] // TODO #163: simplify some of the callback types with type aliases
+#![expect(clippy::type_complexity)] // TODO(#163): simplify some of the callback types with type aliases
 
 use std::ops::RangeInclusive;