Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Response::closed and investigate generalizing popup::OpenKind as something that could be used with Window, Collapsing, Area etc... #5727

Open
lucasmerlin opened this issue Feb 18, 2025 · 2 comments
Open

Add Response::closed and investigate generalizing popup::OpenKind as something that could be used with Window, Collapsing, Area etc... #5727

lucasmerlin opened this issue Feb 18, 2025 · 2 comments
Labels
egui feature New feature or request

Comments

@lucasmerlin
Copy link
Collaborator

lucasmerlin commented Feb 18, 2025 •
edited
Loading

See #5713 (comment)

#5713 (comment)
@lucasmerlin lucasmerlin added egui feature New feature or request labels Feb 18, 2025
@lucasmerlin lucasmerlin mentioned this issue Feb 18, 2025
Merged
5 tasks
@YgorSouza
Copy link
Contributor

Similar to #3752. The discussion there might be useful.

@lucasmerlin
Copy link
Collaborator Author

Ah nice, yeah maybe we could just add that Response::finished and use that for communicating "close me" as well

@lucasmerlin lucasmerlin mentioned this issue Feb 19, 2025
Merged
1 task
lucasmerlin added a commit that referenced this issue Feb 20, 2025
@lucasmerlin @emilk
Add Ui::close and Response::should_close (#5729)
f5b058b 
This adds a generic way of telling containers to close from their child
`Ui`s.

* Part of #5727 
* [x] I have followed the instructions in the PR template

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
egui feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucasmerlin @YgorSouza