Fix all the major linting errors

Author: Jonty

apps/app_library/main.py

@@ -10,7 +10,7 @@
 import http_client
 import wifi
 import dialogs
-from app import *
+from app import App, get_local_apps, get_public_apps, get_public_app_categories, empty_local_app_cache
 import filesystem
 
 TEMP_FILE = ".temp_download"
@@ -149,7 +149,7 @@ def store_category(category):
 def store_details(category, app):
     clear()
     empty_local_app_cache()
-    with dialogs.WaitingMessage(text="Fetching app information...", title="TiLDA App Library") as message:
+    with dialogs.WaitingMessage(text="Fetching app information...", title="TiLDA App Library"):
         app.fetch_api_information()
 
     clear()
@@ -177,7 +177,7 @@ def remove():
 
     if app:
         clear()
-        with dialogs.WaitingMessage(text="Removing %s\nPlease wait..." % app, title="TiLDA App Library") as message:
+        with dialogs.WaitingMessage(text="Removing %s\nPlease wait..." % app, title="TiLDA App Library"):
             for file in os.listdir(app.folder_path):
                 os.remove(app.folder_path + "/" + file)
             os.remove(app.folder_path)

apps/changename/main.py

@@ -5,7 +5,7 @@
 ### Appname : Change name
 
 import dialogs
-from database import *
+from database import Database
 import buttons
 import ugfx
 

apps/home/draw_name.py

@@ -1,6 +1,5 @@
 import ugfx
-from database import *
-from filesystem import *
+from database import database_get
 
 obj = []
 sty = None

apps/home/file_loader.py

@@ -3,13 +3,10 @@
 import pyb
 import buttons
 import dialogs
-from database import *
-from filesystem import *
-import uio
-import sys
+from database import database_get, database_set
+from filesystem import is_dir, is_file
 import gc
-import onboard
-from app import *
+from app import get_local_apps, get_local_app_categories
 
 ugfx.init()
 buttons.init()
@@ -73,8 +70,6 @@ def file_loader():
 	components.append(author)
 	components.append(desc)
 
-	app_to_load = None
-
 	pinned = database_get("pinned_apps", [])
 	catergories = get_local_app_categories()
 	c_ptr = 0

apps/home/home.py

@@ -8,16 +8,16 @@
 
 import ugfx
 import pyb
-from database import *
-from filesystem import *
+from database import Database
+from filesystem import is_file
 import buttons
 import gc
 import apps.home.draw_name
 import wifi
 from imu import IMU
 import onboard
 import dialogs
-from app import *
+from app import get_local_apps
 import sys
 import ntp
 
@@ -172,8 +172,6 @@ def home_main():
 	win_wifi.show()
 	win_clock.show()
 
-	min_ctr = 28
-
 	# Create external hooks so other apps can run code in the context of
 	# the home screen.
 	# To do so an app needs to have an external.py with a tick() function.

apps/home/quick_launch.py

@@ -2,10 +2,9 @@
 import pyb
 import buttons
 import dialogs
-from database import *
-from filesystem import *
+from database import Database, database_get, database_set
 import gc
-from app import *
+from app import App, empty_local_app_cache
 
 ugfx.init()
 ugfx.set_default_style(dialogs.default_style_badge)
@@ -52,8 +51,6 @@ def quick_launch_screen():
 	btn_menu = ugfx.Button(200,5,20,20,"M",parent=win_help,shape=ugfx.Button.ROUNDED)
 	l_menu = ugfx.Label(230,5,100,20,"Menu",parent=win_help)
 
-	sty = dialogs.default_style_badge
-
 	win_header.show()
 	win_quick.show()
 	win_help.show()
@@ -63,8 +60,6 @@ def quick_launch_screen():
 	last_cursor = cursor.copy()
 	_draw_cursor(0, 0, ugfx.RED, win_quick)
 
-	app_to_load = "home"
-
 	if not database_get("quicklaunch_firstrun"):
 		dialogs.notice("""This screen displays the most commonly used apps.
 Apps pinned here can also interact with the name screen.

apps/logger/external.py

@@ -1,5 +1,5 @@
-from filesystem import *
-from database import *
+from filesystem import is_file
+from database import database_get
 import stm
 import http_client
 import wifi
@@ -13,7 +13,7 @@ def tick():
 	bv = str(onboard.get_battery_voltage())
 	uv = str(onboard.get_unreg_voltage())
 	li = str(onboard.get_light())
-	rssi = wifi.nic().get_rssi()
+	wifi.nic().get_rssi()
 
 	aps = wifi.nic().list_aps()
 	highest_rssi = -200
@@ -37,7 +37,7 @@ def tick():
 	if database_get("stats_upload"):
 		try:
 			if wifi.nic().is_connected():
-				with http_client.post('http://api.badge.emfcamp.org/api/barms', json=json) as resp:
+				with http_client.post('http://api.badge.emfcamp.org/api/barms', json=json):
 					pass
 		except OSError as e:
 			print("Upload failed " + str(e))

apps/logger/main.py

@@ -6,8 +6,8 @@
 ### Built-in: yes
 
 import ugfx
-from filesystem import *
-from database import *
+from filesystem import is_file
+from database import database_get, database_set
 import pyb
 import math
 import buttons

examples/adc.py

@@ -1,6 +1,7 @@
 #This example shows how to use the ADC, and how to 
 # measure the internal reference to get a more accurate
 # ADC reading
+import pyb
 
 # set adc resolution to 12 bits
 adca = pyb.ADCAll(12)
@@ -20,4 +21,4 @@
 # now calculate the USB voltage
 usb_voltage = usb_reading/4095*supply_voltage*2
 
-print("usb_voltage: " + str(usb_voltage) + "\n")
+print("usb_voltage: " + str(usb_voltage) + "\n")

examples/dactest.py

@@ -1,4 +1,5 @@
-dac = DAC(2)
+import pyb
+dac = pyb.DAC(2)
 
 countdown = 10
 
@@ -7,4 +8,4 @@
 
 	pyb.delay(300)
 
-	countdown -= 10
+	countdown -= 10

examples/http.py

@@ -1,5 +1,5 @@
 import wifi
-from http_client import *
+from http_client import get
 
 wifi.connect()
 

examples/read_light.py

@@ -1,7 +1,8 @@
+import pyb
 
 #light sensor is on PA3 (note change this)
 a = pyb.ADC('PA3')
 
 while True:
 	print(str(a.read()))
-	pyb.delay(1000)
+	pyb.delay(1000)

examples/set_rtc_from_ntp.py

@@ -13,7 +13,7 @@ def getntptime():
     NTP_QUERY[0] = 0x1b
     addr = socket.getaddrinfo(host, 123)[0][-1]
     s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
-    res = s.sendto(NTP_QUERY, addr)
+    s.sendto(NTP_QUERY, addr)
     msg = s.recv(48)
     s.close()
     import struct

lib/dialogs.py

@@ -114,7 +114,7 @@ def prompt_text(description, init_text = "", true_text="OK", false_text="Back",
 		label.destroy()
 		kb.destroy()
 		edit.destroy();
-	return default
+	return
 
 def prompt_option(options, index=0, text = "Please select one of the following:", title=None, select_text="OK", none_text=None):
 	"""Shows a dialog prompting for one of multiple options

lib/filesystem.py

@@ -2,7 +2,9 @@
 ### Description: Small set of micropython specific filesystem helpers
 ### License: MIT
 
-import os, hashlib, binascii
+import os
+import hashlib
+import binascii
 
 def get_app_foldername(path):
 	"""Gets the app name based on a path"""
@@ -39,7 +41,7 @@ def get_app_attribute(path, attribute):
 				else:
 					break
 
-	except OSError as e:
+	except OSError:
 		return ""
 	return rv
 

lib/ntp.py

@@ -2,7 +2,6 @@
 ### License: MIT
 
 import database
-import pyb
 import socket
 
 
@@ -17,7 +16,7 @@ def get_NTP_time():
 	NTP_QUERY[0] = 0x1b
 	addr = socket.getaddrinfo(NTP_HOST, NTP_PORT)[0][-1]
 	s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
-	res = s.sendto(NTP_QUERY, addr)
+	s.sendto(NTP_QUERY, addr)
 
 	# Setting timeout for receiving data. Because we're using UDP,
 	# there's no need for a timeout on send.