Skip to content

Commit 8cbdae7

Browse files
committed
Don't rebuild internal types under entire TS matrix
1 parent e7deb82 commit 8cbdae7

File tree

3 files changed

+78
-38
lines changed

3 files changed

+78
-38
lines changed

.github/workflows/ci-jobs.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,10 @@ jobs:
3535
- uses: ./.github/actions/setup
3636
- name: build types
3737
run: pnpm build:types
38-
- name: Check published and internal types
39-
run: pnpm type-check
38+
- name: Check internal types
39+
run: pnpm type-check:internals
40+
- name: Check published types
41+
run: pnpm type-check:types
4042

4143
types-range:
4244
name: Type Checking (other supported versions)
@@ -54,8 +56,8 @@ jobs:
5456
run: pnpm build:types
5557
- name: install TS@${{matrix.ts-version}}
5658
run: pnpm add --save-dev --workspace-root typescript@${{ matrix.ts-version }}
57-
- name: Check published and internal types with TS@${{matrix.ts-version}}
58-
run: pnpm type-check
59+
- name: Check published types
60+
run: pnpm type-check:types
5961

6062
basic-test:
6163
name: Basic Test

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"test:browserstack": "node bin/run-browserstack-tests.js",
6161
"test:wip": "vite build --mode development --minify false && testem ci",
6262
"type-check:internals": "tsc --noEmit",
63-
"type-check:types": "pnpm build:types && tsc --noEmit --project type-tests",
63+
"type-check:types": "tsc --noEmit --project type-tests",
6464
"type-check": "npm-run-all type-check:*",
6565
"unlink:all": "node bin/unlink-all.mjs"
6666
},
@@ -151,7 +151,7 @@
151151
"terser": "^5.42.0",
152152
"testem": "^3.10.1",
153153
"testem-failure-only-reporter": "^1.0.0",
154-
"typescript": "^5.7.3",
154+
"typescript": "^5.2.2",
155155
"typescript-eslint": "^8.26.0",
156156
"vite": "^5.4.12"
157157
},

pnpm-lock.yaml

Lines changed: 70 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)