Probably error in tutorial, Part 2, Section "Route Params"

[kisumoto]

I'm following that tutorial. My env:

ember-cli: 3.18.0
node: 12.18.0
os: linux x64

Tutorial link: https://guides.emberjs.com/release/tutorial/part-2/route-params/
Version selected: 3.18.

Tutorial recommends to add test:

    assert.dom('article h3 a').hasAttribute('href', '/rentals/grand-old-mansion');

but that test doesn't pass even after routing is enabled. Here is what I've got to pass:

    assert.dom('article h3 a').hasAttribute('href', '/rental/grand-old-mansion');

Difference in rentalS => rental in URL.

[kisumoto]

Similar error on the same page:

    assert.equal(currentURL(), '/rentals/grand-old-mansion');

Again here works test with rental instead of rentalS.

And whole test case below

  test('visiting /rental/grand-old-mansion', async function (assert) {
    await visit('/rental/grand-old-mansion');

    assert.equal(currentURL(), '/rental/grand-old-mansion');
    assert.dom('nav').exists();
    assert.dom('h1').containsText('SuperRentals');
    assert.dom('h2').containsText('Grand Old Mansion');
    assert.dom('.rental.detailed').exists();
  });

Here I already replaced rentalS with rental.

[chancancode]

Perhaps you defined the route with the singular name in app/routes.js? Nothing wrong with that, the name is not special, they just have to match as you have discovered. The code in the tutorial is automatically executed and tested daily, so I am pretty sure the tests do pass as written.

[kisumoto]

Indeed :) Magic Ember! Everything worked like a charm with typo. I mean it loaded component, embed proper LinkTo hrefs, and everything else, except tests where I explicitly ask for /rentals/. Thank you.

[kisumoto]

I finished the tutorial, both parts. It works fine. Probably only one minor issue is in this promise:
https://guides.emberjs.com/release/tutorial/part-2/service-injection/

Feel free to try sending the tweet! However, keep in mind that your followers cannot access your local server at http://localhost:4200/. Don't worry though, at the end of the tutorial, we will deploy the app to the Internet so you can show everyone what you made!

Tutorial doesn't teach this thing :)

[amyrlam]

@kisumoto thank you, I filed an issue for that: https://github.com/ember-learn/guides-source/issues/1454

If you happen to be interested in making the change (no worries if not!), please comment on the issue!

[roderickdevelopers]

I will look into it and take care of this issue this week!

[chancancode]

@amyrlam @roderickdevelopers thanks for picking it up, as a reminder the PR should be sent to https://github.com/ember-learn/super-rentals-tutorial. We do intend to cover it (tracked in ember-learn/super-rentals-tutorial#137), just haven't had a chance to do it yet.