Skip to content

Commit 8227d71

Browse files
committed
fix implicit-injections deprecation
1 parent 4ae19a8 commit 8227d71

File tree

10 files changed

+112
-13
lines changed

10 files changed

+112
-13
lines changed

app/app.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,11 @@ import Application from '@ember/application';
22
import Resolver from 'ember-resolver';
33
import loadInitializers from 'ember-load-initializers';
44
import config from 'ember-api-docs/config/environment';
5+
import { importSync, isDevelopingApp, macroCondition } from '@embroider/macros';
56

6-
import './deprecation-workflow';
7+
if (macroCondition(isDevelopingApp())) {
8+
importSync('./deprecation-workflow');
9+
}
710

811
export default class App extends Application {
912
modulePrefix = config.modulePrefix;

app/deprecation-workflow.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import setupDeprecationWorkflow from 'ember-cli-deprecation-workflow';
22

33
setupDeprecationWorkflow({
4+
throwOnUnhandled: true,
45
workflow: [
5-
{ handler: 'silence', matchId: 'ember.component.reopen' },
6-
{ handler: 'silence', matchId: 'implicit-injections' },
6+
{ handler: 'throw', matchId: 'ember.component.reopen' },
7+
{ handler: 'throw', matchId: 'implicit-injections' },
78
{ handler: 'silence', matchId: 'this-property-fallback' },
89
{ handler: 'silence', matchId: 'ember-component.is-visible' },
910
{

app/routes/project-version.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ export default class ProjectVersionRoute extends Route {
2121
@service
2222
router;
2323

24+
@service store;
25+
2426
@service('project')
2527
projectService;
2628

app/routes/project-version/classes/class.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ export default class ClassRoute extends Route.extend(ScrollTracker) {
1818
@service
1919
metaStore;
2020

21+
@service store;
22+
2123
titleToken(model) {
2224
return model.name;
2325
}

app/routes/project-version/functions/function.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ export default class FunctionRoute extends Route {
1414
@service
1515
scrollPositionReset;
1616

17+
@service store;
18+
1719
titleToken(model) {
1820
return model?.fn?.name;
1921
}

app/routes/project-version/modules/module.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import ClassRoute from '../classes/class';
22
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
33
import getFullVersion from 'ember-api-docs/utils/get-full-version';
4+
import { inject as service } from '@ember/service';
45

56
export default class ModuleRoute extends ClassRoute.extend(ScrollTracker) {
7+
@service store;
8+
69
async model(params) {
710
const { project, project_version: compactVersion } =
811
this.paramsFor('project-version');

app/routes/project-version/namespaces/namespace.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import ClassRoute from '../classes/class';
22
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
33
import getFullVersion from 'ember-api-docs/utils/get-full-version';
4+
import { inject as service } from '@ember/service';
45

56
export default class NamespaceRoute extends ClassRoute.extend(ScrollTracker) {
7+
@service store;
8+
69
templateName = 'project-version/classes/class';
710

811
async model(params) {

app/routes/project.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ export default class ProjectRoute extends Route.extend(ScrollTracker) {
77
@service
88
router;
99

10+
@service store;
11+
1012
model({ project: projectName }) {
1113
let projectNameToLookUp = 'ember';
1214

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"@ember/test-helpers": "^2.6.0",
3232
"@embroider/compat": "^3.4.3",
3333
"@embroider/core": "^3.4.3",
34+
"@embroider/macros": "^1.18.0",
3435
"@embroider/webpack": "^3.2.1",
3536
"@glimmer/component": "^1.1.2",
3637
"@glimmer/tracking": "^1.1.2",

pnpm-lock.yaml

Lines changed: 90 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)