Skip to content

Commit f6706fa

Browse files
authored
Fix 404 error when attempting to download OpenVSX extensions (#762)
This change fixes this error when running `(dap-node-setup)`: `url-insert-file-contents: https://open-vsx.org/api/ms-vscode/node-debug2/latest/: Not found` The problem was that the OpenVSX URL template string had a trailing slash, which is not handled by OpenVSX's Registry API Controller: https://github.com/eclipse/openvsx/blob/master/server/src/main/java/org/eclipse/openvsx/RegistryAPI.java#L348 I can't really find a blame in the OpenVSX repo which could've caused the extraneous trailing slash. Maybe the update to Java 17? As you can see, there's no trailing slash at the end, so the route doesn't get mached in the controller and causes a 404 Not Found. Just removing the slash does the job and `(dap-node-setup)` runs successfully. References: - #554 (comment) - #700
1 parent 1187c69 commit f6706fa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

dap-utils.el

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
:type 'string)
6262

6363
(defcustom dap-utils-openvsx-extension-api-url
64-
"https://open-vsx.org/api/%s/%s/%s/"
64+
"https://open-vsx.org/api/%s/%s/%s"
6565
"Open VSX extension api url."
6666
:group 'dap-utils
6767
:type 'string)

0 commit comments

Comments
 (0)