Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in dev.sh - When using "pnpm dev --character=xx", the character fails to load #2381

Open
MyJoiT opened this issue Jan 16, 2025 · 2 comments
Labels
bug Something isn't working Needs Refactor

Comments

@MyJoiT
Copy link

MyJoiT commented Jan 16, 2025

Describe the bug

When using the pnpm dev --character="characters/trump.character.json" command, the character parameter fails to load correctly, resulting in only the default character being loaded.

To Reproduce

step 1:
open the dev.sh file
vim scripts/dev.sh

step 2:

add a new path for WORKING_FOLDERS

# List of working folders to watch (relative to $PACKAGES_DIR)
WORKING_FOLDERS=("client-direct" "plugin-test") # Core is handled separately

step 3:
run
pnpm dev --character="characters/trump.character.json"

step 4:
Will see that the default character "Eliza" has been loaded, instead of the specified "trump.character.json"

Expected behavior

Character "trump" should be loaded

Screenshots

No screenshots

Additional context

The reason for this situation is that a wrong symbol was used in dev.sh

Image

Should use * instead of @
Using @ causes the command to be forcibly wrapped into a new line (and it's an incorrect line break)

This is the correct code:

COMMANDS+=("nodemon ${WATCH_PATHS[*]} -e js,json,map --delay 2 --exec 'pnpm --dir agent dev -- $*'")
@MyJoiT MyJoiT added the bug Something isn't working label Jan 16, 2025
Copy link
Contributor

Hello @MyJoiT! Welcome to the elizaOS community. Thank you for opening your first issue; we appreciate your contribution. You are now an elizaOS contributor!

@AIFlowML
Copy link
Collaborator

Hello @MyJoiT nice catch.
Wanna push a PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs Refactor
Projects
None yet
Development

No branches or pull requests

2 participants