Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url/delete not overridable #49

Closed
ah0y opened this issue Jul 30, 2023 · 2 comments
Closed

Url/delete not overridable #49

ah0y opened this issue Jul 30, 2023 · 2 comments

Comments

@ah0y
Copy link

ah0y commented Jul 30, 2023 •
edited
Loading

waffle_ecto is an awesome library! However I'm running into issues with overriding url/3 and delete/1 in my definition

I've opened #50 and verified that I can now override url. Is what I'm doing correct? I have no idea as I've never done any meta-programming before.
@ah0y ah0y changed the title Url not overridable Url/delete not overridable Jul 30, 2023
@achempion
Copy link
Member

Hi, Abe

What is your use case for overriding the url/delete functions? Will just creating a function with a different name work?

@ah0y
Copy link
Author

ah0y commented Aug 1, 2023

On second thought I don't actually need to override url/delete and can just make new functions. Thanks for the suggestion!

@ah0y ah0y closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@achempion @ah0y