Skip to content

Commit 0a36c0b

Browse files
authored
Update workflow to run similar to exqlite (#54)
* Update workflow to run similar to exqlite * Remove message assertion for argument error
1 parent 03633dc commit 0a36c0b

File tree

2 files changed

+33
-40
lines changed

2 files changed

+33
-40
lines changed

.github/workflows/ci.yml

Lines changed: 33 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,44 +7,49 @@ on:
77
- main
88

99
jobs:
10+
lint:
11+
runs-on: ubuntu-20.04
12+
env:
13+
MIX_ENV: test
14+
name: Lint
15+
steps:
16+
- uses: actions/checkout@v2
17+
- uses: erlef/setup-elixir@v1
18+
with:
19+
otp-version: "24"
20+
elixir-version: "1.12"
21+
- run: mix deps.get && mix deps.unlock --check-unused
22+
- run: mix format --check-formatted
1023
test:
1124
runs-on: ubuntu-20.04
1225
env:
1326
MIX_ENV: test
27+
name: Ubuntu / OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}}
1428
strategy:
1529
fail-fast: false
1630
matrix:
1731
include:
18-
- pair:
19-
elixir: 1.8.2
20-
otp: 20.3.8.26
21-
- pair:
22-
elixir: 1.11.4
23-
otp: 23.2.7
24-
lint: lint
32+
- elixir: "1.12"
33+
otp: "24"
34+
- elixir: "1.12"
35+
otp: "23"
36+
- elixir: "1.11"
37+
otp: "24"
38+
- elixir: "1.11"
39+
otp: "23"
40+
- elixir: "1.10"
41+
otp: "24"
42+
- elixir: "1.10"
43+
otp: "23"
44+
- elixir: "1.8"
45+
otp: "20"
2546
steps:
2647
- uses: actions/checkout@v2
27-
2848
- uses: erlef/setup-elixir@v1
2949
with:
30-
otp-version: ${{matrix.pair.otp}}
31-
elixir-version: ${{matrix.pair.elixir}}
32-
33-
- name: Install Dependencies
34-
run: mix deps.get --only test
35-
36-
- run: mix format --check-formatted
37-
if: ${{ matrix.lint }}
38-
39-
- run: mix deps.get && mix deps.unlock --check-unused
40-
if: ${{ matrix.lint }}
41-
50+
otp-version: ${{matrix.otp}}
51+
elixir-version: ${{matrix.elixir}}
52+
- run: mix deps.get --only test
4253
- run: mix deps.compile
43-
44-
# test/support throwing compile errors, but will soon be refactored
45-
# - run: mix compile --warnings-as-errors
46-
# if: ${{ matrix.lint }}
47-
48-
- run: mix test --trace
49-
50-
- run: EXQLITE_INTEGRATION=true mix test --trace
54+
- run: mix compile
55+
- run: mix test

test/ecto/adapters/sqlite3/connection_test.exs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2368,20 +2368,8 @@ defmodule Ecto.Adapters.SQLite3.ConnectionTest do
23682368
end
23692369

23702370
test "create table with an unsupported type" do
2371-
msg =
2372-
if :erlang.system_info(:otp_release) >= '24' do
2373-
"""
2374-
errors were found at the given arguments:
2375-
2376-
* 1st argument: not an atom
2377-
"""
2378-
else
2379-
"argument error"
2380-
end
2381-
23822371
assert_raise(
23832372
ArgumentError,
2384-
msg,
23852373
fn ->
23862374
{:create, table(:posts),
23872375
[

0 commit comments

Comments
 (0)