From 5607e62fef0f238a7ef47455b4bdd79efb61b2db Mon Sep 17 00:00:00 2001 From: Javed Habib Date: Mon, 14 Oct 2024 10:53:10 +0530 Subject: [PATCH] remove todo and fixme --- tesk/k8s/converter/converter.py | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/tesk/k8s/converter/converter.py b/tesk/k8s/converter/converter.py index 6ab704c..9c58a34 100644 --- a/tesk/k8s/converter/converter.py +++ b/tesk/k8s/converter/converter.py @@ -94,18 +94,6 @@ def from_tes_task_to_k8s_job(self, task: TesTask) -> V1Job: taskmaster_job.metadata.annotations[ self.tesk_k8s_constants.annotation_constants.ANN_TESTASK_NAME_KEY ] = task.name - # taskmaster_job.metadata.labels[self.constants.label_userid_key] = user[ - # "username" - # ] - - # if task.tags and "GROUP_NAME" in task.tags: - # taskmaster_job.metadata.labels[self.constants.label_userid_key] = task[ - # "tags" - # ]["GROUP_NAME"] - # elif user["is_member"]: - # taskmaster_job.metadata.labels[self.constants.label_groupname_key] = user[ - # "any_group" - # ] json_input = json.dumps( task.dict(), @@ -170,23 +158,16 @@ def from_tes_task_to_k8s_config_map( if taskmaster_config_map.metadata.annotations is None: taskmaster_config_map.metadata.annotations = {} - # FIXME: What if the task name is None? - task_name = task.name or "task-name-not-set" + task_name = task.name or "String" taskmaster_config_map.metadata.annotations[ self.tesk_k8s_constants.annotation_constants.ANN_TESTASK_NAME_KEY ] = task_name - # taskmaster_config_map.metadata.labels[self.constants.label_userid_key] - # = user["username"] - if task.tags and "GROUP_NAME" in task.tags: taskmaster_config_map.metadata.labels[ self.tesk_k8s_constants.label_constants.LABEL_GROUPNAME_KEY ] = task.tags["GROUP_NAME"] - # elif user["is_member"]: - # taskmaster_config_map.metadata.labels[self.constants.label_groupname_key] - # = user["any_group"] assert taskmaster_config_map.metadata.name is not None assert task.resources is not None