Skip to content

Add benchmarks #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eliotwrobson opened this issue Nov 5, 2024 · 1 comment · Fixed by #29
Closed

Add benchmarks #26

eliotwrobson opened this issue Nov 5, 2024 · 1 comment · Fixed by #29
Labels
documentation Improvements or additions to documentation

Comments

@eliotwrobson
Copy link
Owner

Add benchmarks using ASV, from discussion here.

@eliotwrobson eliotwrobson added the documentation Improvements or additions to documentation label Nov 5, 2024
@eliotwrobson
Copy link
Owner Author

Looking at various options, I think I will opt to add benchmarks that are run as a workflow using pytest benchmark. I don't think this project has quite the size for something like ASV to be super necessary (there are only a couple of operations we care about, and these are all being done with the same code). We can always go back and add this later, but frankly I don't expect the code to change that much once the PyOS review is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant