Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of unsubscriber in the core app so that when someone clicks unsubscribe we do the unsub for them #246

Open
elie222 opened this issue Oct 18, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@elie222
Copy link
Owner

elie222 commented Oct 18, 2024

If the unsubscribe is unsuccessful then we can have the user finish the flow themselves.

Also note that some unsub links are actually just to send an email, so we can skip using the unsubscriber for those.

PR for unsubscriber is here, but it's yet to be used in the web app.
#236

CC @madhav-relish

@elie222 elie222 changed the title Make use of unsubscriber in the core app Make use of unsubscriber in the core app so that when someone clicks unsubscribe we do the unsub for them Oct 18, 2024
@elie222
Copy link
Owner Author

elie222 commented Oct 18, 2024

Important: the app should work without this as well. Because running it in this mode means running another service, it will be easier for self hosters to not have to use the unsubscriber if they don't want to.

This can be enabled via an env var: UNSUBSCRIBER_URL and if it's not set then it isn't used.

@elie222
Copy link
Owner Author

elie222 commented Mar 26, 2025

Most of the code for the task is here, but the code in that PR has not been tested. You can use it for reference (no need to build off of that PR):
#376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant