Replace node-inspect with chrome-remote-interface (#21)

Author: eliba2

.gitignore

@@ -2,6 +2,7 @@
 breakpoints
 vim-node-config.json
 vim-node-session.json
+node_modules
 
 # Sometimes I'm on Mac
 .DS_Store

README.md

@@ -2,7 +2,7 @@
 Interactive node debugger for (n)vim.
 
 ## Description
-Node debugging capabilities for (n)vim using the devtools protocol. Under the hood it wraps a modified version of node-inspect *(https://github.com/nodejs/node-inspect)*.
+Node debugging capabilities for (n)vim using the devtools protocol.
 
 
 [![asciicast](https://asciinema.org/a/NOCL8Fc3LcQjVDD0CIR08I698.svg)](https://asciinema.org/a/NOCL8Fc3LcQjVDD0CIR08I698)
@@ -18,13 +18,14 @@ Plug 'eliba2/vim-node-inspect'
 ```
 
 ## How to use
-Either start a node script or attach to an already running script. Both can be done manually (NodeIndpectStart/NodeInspectRun) or using the configuration file vim-node-config.json. The later is encouraged.
 
-For full documentation see :h vim-node-inspect.
+Use the plugin to start a script with *NodeInspectStart*/*NodeInspectRun* or attach to an already running script using *NodeInspectConnect*. Additional configuration can be set with the vim-node-config.json configuration file.
 
-### Starting Manually ###
+For full documentation see `:h vim-node-inspect`.
 
-Either start debugging a local js file (via NodeInspectStart or NodeInspectRun) or connect to a running instance using NodeInspectConnect. In the later case the target must start with --inspect (e.g. node --inspect server.js). 
+### W/O A configuration file ###
+
+Use NodeInspectStart or NodeInspectRun which starts the script in the current buffer using `node --inspect <script>`. An already running script can be attached using NodeInspectConnect address:port. In the later case the target must start with --inspect (e.g. `node --inspect server.js`). 
 
 ### Using the configuration file ###
 
@@ -123,8 +124,6 @@ Usage in this case would be either *NodeInspectStart "run"* or *NodeInspectStart
 
 ## Available Commands
 
-The following commands are available:
-
 **NodeInspectStart [config name] [args]** - Starts debugger, paused
 
 **NodeInspectRun [config name] [args]** - Continue / Start and run immediatly
@@ -150,13 +149,16 @@ The following commands are available:
 
 There are no default bindings; the following is added for convinience:
 ```
-nnoremap <silent><F4> :NodeInspectStart<cr>
-nnoremap <silent><F5> :NodeInspectRun<cr>
-nnoremap <silent><F6> :NodeInspectConnect("127.0.0.1:9229")<cr>
-nnoremap <silent><F7> :NodeInspectStepInto<cr>
-nnoremap <silent><F8> :NodeInspectStepOver<cr>
-nnoremap <silent><F9> :NodeInspectToggleBreakpoint<cr>
-nnoremap <silent><F10> :NodeInspectStop<cr>
+nnoremap <silent><leader>dd :NodeInspectStart<cr>
+nnoremap <silent><leader>dr :NodeInspectRun<cr>
+nnoremap <silent><leader>dc :NodeInspectConnect("127.0.0.1:9229")<cr>
+nnoremap <silent><leader>ds :NodeInspectStepOver<cr>
+nnoremap <silent><leader>di :NodeInspectStepInto<cr>
+nnoremap <silent><leader>do :NodeInspectStepOut<cr>
+nnoremap <silent><leader>dq :NodeInspectStop<cr>
+nnoremap <silent><leader>db :NodeInspectToggleBreakpoint<cr>
+nnoremap <silent><leader>da :NodeInspectRemoveAllBreakpoints<cr>
+nnoremap <silent><leader>dw :NodeInspectToggleWindow<cr>
 ```
 
 ## Breakpoints
@@ -200,13 +202,6 @@ The debugger windows appear on the bottom by default. Change it by using
 let g:nodeinspect_window_pos = 'right'|'left'|'bottom'
 ```
 
-The command window starts in repl mode by default. It gives you a javascript shell corresponding to the current scope. If you are familiar with node-inspect and/or want to use the command mode - which enables executing debugging commands manually - use the following setting:
-
-```
-let g:nodeinspect_start_repl = 0
-```
-
-
 ## Remarks
 In beta. Means its useful; things may change or fail.
 
@@ -217,21 +212,21 @@ Tested on Linux (debian), OSX, Windows.
 
 * Debugging window
 	* Detachable 
-	* position change
+	* ~~position change~~
 * Watches
-	* Auto watches
-	* Open/Close properties
+	* ~~Auto watches~~
+	* ~~Open/Close properties~~
 	* On the fly evaluation (popup)
 * Breakpoints
 	* Breakpoints window
 * Call stack
 	* Auto jump
-* Windows Support
+* ~~Windows Support~~
 
 
 ## Contributing
 
-PR are welcome. Open a new issue in case you find a bug; you can also create a PR fixing it yourself of course.
+PRs welcome. Open a new issue in case you find a bug; you can also create a PR fixing it yourself of course.
 Please follow the general code style (look@the code) and in your pull request explain the reason for the proposed change.
 
 

autoload/nodeinspect.vim

@@ -1,4 +1,4 @@
-let s:status = 0 " 0 - not started. 1 - started 2 - session ended (bridge exists, node exited) 3 - restarting
+let s:status = 0 " 0 - not started. 1 - started 2 - session ended (bridge exists, node exited) 3 - restarting (not used)
 let s:plugin_path = expand('<sfile>:h:h')
 let s:sign_id = 2
 let s:brkpt_sign_id = 3
@@ -171,6 +171,12 @@ endfunction
 " remove all breakpoints. removes the signs is any
 " node inspect notification will ocuur only if started
 function! s:NodeInspectRemoveAllBreakpoints(inspectNotify)
+	" notify bride if up
+	if a:inspectNotify == 1 && s:status == 1
+		let remoteFiles = s:getRemoteBreakpointsObj(s:breakpoints)
+		call nodeinspect#utils#SendEvent('{"m": "nd_removeallbrkpts", "breakpoints":' . json_encode(remoteFiles) . '}')
+	endif
+	" remove vim breakpoints
 	for filename in keys(s:breakpoints)
 		for line in keys(s:breakpoints[filename])
 			let signId = s:breakpoints[filename][line]
@@ -180,10 +186,6 @@ function! s:NodeInspectRemoveAllBreakpoints(inspectNotify)
 			endif
 		endfor
 	endfor
-	if a:inspectNotify == 1 && s:status == 1
-		let remoteFiles = s:getRemoteBreakpointsObj(s:breakpoints)
-		call nodeinspect#utils#SendEvent('{"m": "nd_removeallbrkpts", "breakpoints":' . json_encode(remoteFiles) . '}')
-	endif
 endfunction
 
 " called when node resolves this to a location.
@@ -318,7 +320,7 @@ function! s:onDebuggerStopped(mes)
 		call nodeinspect#backtrace#ClearBacktraceWindow('Debugger Stopped. Source file is not available')
 	endif
 	" request watches update	
-	call nodeinspect#watches#UpdateWatches()
+	" call nodeinspect#watches#UpdateWatches()
 endfunction
 
 
@@ -396,10 +398,8 @@ function! OnNodeMessage(channel, msgs)
 				call nodeinspect#NodeInspectStepInto()
 			elseif mes["m"] == "nd_repl_stepout"
 				call nodeinspect#NodeInspectStepOut()
-			" if the repl was started node-inspect, go to repl mode there (js
-			" command mode)
-			elseif mes["m"] == "nd_repl_started"
-				call nodeinspect#utils#StartRepl()
+			elseif mes["m"] == "nd_resolvedobject"
+				call nodeinspect#watches#ResolvedObject(mes['objectId'], mes['tokens'])
 			else
 				echo "vim-node-inspect: unknown message ".mes["m"]
 			endif
@@ -582,8 +582,8 @@ function! s:NodeInspectStart()
 				let s:session["script"] = expand('%:p')
 			endif
 		endif
-		" set the status to running, might be at ended(2)
-		let s:status = 3
+		" set the status to started, might be at ended(2)
+		let s:status = 1
         " restarting might need to restart external jobs, if any
 		let repl_result = nodeinspect#repl#StartExternalJobs(s:session)
 		if repl_result != 0
@@ -592,6 +592,8 @@ function! s:NodeInspectStart()
 			return
 		endif
 		" remove all breakpoint, they will be resolved by node-inspect
+	echom "status is ".s:status
+		
 		call s:removeSign()
 		call nodeinspect#backtrace#ClearBacktraceWindow()
 		call nodeinspect#utils#SendEvent('{"m": "nd_restart", "script": "'. s:session["script"] . '","args": ' . json_encode(s:session["args"]) . '}')
@@ -616,7 +618,6 @@ function! s:NodeInspectStart()
 	for watch in keys(s:session["watches"])
 		call nodeinspect#watches#AddBulk(s:session["watches"])
 	endfor
-
 endfunction
 
 
@@ -655,7 +656,7 @@ endfunction
 
 function! nodeinspect#NodeInspectStepOver()
 	if s:status != 1
-		echo "node-inspect not started"
+		echo "node-inspect not started ".s:status
 		return
 	endif
 	call s:NodeInspectStepOver()

autoload/nodeinspect/backtrace.vim

@@ -61,18 +61,18 @@ function! nodeinspect#backtrace#ShowBacktraceWindow(startWin)
 		" open split for call stack
 		if s:backtrace_buf == -1
 			if g:nodeinspect_window_pos == 'right' || g:nodeinspect_window_pos == 'left'
-				execute winheight(a:startWin)/3."new | setlocal nobuflisted buftype=nofile statusline=Callstack"
+				execute winheight(a:startWin)/5*2."new | setlocal nobuflisted buftype=nofile statusline=Callstack"
 			else
-				execute "rightb ".winwidth(a:startWin)/3."vnew | setlocal nobuflisted buftype=nofile statusline=Callstack"
+				execute "rightb ".winwidth(a:startWin)/5*2."vnew | setlocal nobuflisted buftype=nofile statusline=Callstack"
 			endif
 
 			let s:backtrace_buf = bufnr('%')
 			set nonu
 		else
 			if g:nodeinspect_window_pos == 'right' || g:nodeinspect_window_pos == 'left'
-				execute winheight(a:startWin)/3."new | buffer ". s:backtrace_buf
+				execute winheight(a:startWin)/5*2."new | buffer ". s:backtrace_buf
 			else
-				execute "rightb ".winwidth(a:startWin)/3."vnew | buffer ". s:backtrace_buf 
+				execute "rightb ".winwidth(a:startWin)/5*2."vnew | buffer ". s:backtrace_buf 
 			endif
 		endif
 		let s:backtrace_win = win_getid()