Skip to content

Commit 0921f6b

Browse files
Merge pull request #432 from element-hq/gaelg/fix-default-keys
MAS: remove default keys from method calls
2 parents 54c8877 + 0f522ab commit 0921f6b

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

charts/matrix-stack/source/matrixAuthenticationService.yaml.j2

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ privateKeys:
3535
{{ sub_schema_values.labels() }}
3636
{{ sub_schema_values.serviceAccount() }}
3737
{{ sub_schema_values.nodeSelector() }}
38-
{{ sub_schema_values.tolerations(global=false, key='tolerations') }}
39-
{{ sub_schema_values.topologySpreadConstraints(global=true, key= 'topologySpreadConstraints') }}
38+
{{ sub_schema_values.tolerations() }}
39+
{{ sub_schema_values.topologySpreadConstraints() }}
4040
{{ sub_schema_values.podSecurityContext(user_id=10005, group_id=10005) }}
41-
{{ sub_schema_values.containersSecurityContext(key='containersSecurityContext') }}
41+
{{ sub_schema_values.containersSecurityContext() }}
4242
{{ sub_schema_values.workloadAnnotations() }}
43-
{{ sub_schema_values.serviceMonitors(key= 'serviceMonitors') }}
43+
{{ sub_schema_values.serviceMonitors() }}
4444
{{ sub_schema_values.extraEnv() }}

charts/matrix-stack/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1234,10 +1234,10 @@ matrixAuthenticationService:
12341234

12351235
tolerations: []
12361236

1237-
## TopologySpreadConstraints describes how Pods for a component should be spread between nodes.
1237+
## TopologySpreadConstraints describes how Pods for this component should be spread between nodes.
12381238
## https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ for in-depth details
1239-
## labelSelector can be omitted and the chart will populate a sensible value for each component.
1240-
## Similarly `pod-template-hash` will be aded to `matchLabelKeys` if appropriate for each component.
1239+
## labelSelector can be omitted and the chart will populate a sensible value for this component.
1240+
## Similarly `pod-template-hash` will be aded to `matchLabelKeys` if appropriate for this component.
12411241
## If any TopologySpreadConstraints are provided for a component any global TopologySpreadConstraints are ignored for that component.
12421242
## e.g.
12431243
## topologySpreadConstraints:

newsfragments/432.internal.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
MAS: Fix schema schema method calls do not need to respecify default keys values.

0 commit comments

Comments
 (0)