Skip to content

Handle threaded pinned events #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 10, 2025
Merged

Handle threaded pinned events #4704

merged 5 commits into from
Nov 10, 2025

Conversation

@Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 5, 2025 •
edited
Loading

fixes #4709

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-11-06.at.16.20.00.mov

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
886 2 884 0
View the full list of 2 ❄️ flaky test(s) 
DeferredFulfillmentTests::testObservableMultipleUpdates()

Flake rate in main: 28.53% (Passed 238 times, Failed 95 times)

Stack Traces | 20.3s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:77)
RoomFlowCoordinatorTests::testThreadedEventRoutes()

Flake rate in main: 33.33% (Passed 24 times, Failed 12 times)

Stack Traces | 0s run time 
XCTAssertEqual failed: ("0") is not equal to ("1") (UnitTests/Sources/RoomFlowCoordinatorTests.swift:246)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Velin92 Velin92 marked this pull request as ready for review November 6, 2025 15:26
@Velin92 Velin92 requested a review from a team as a code owner November 6, 2025 15:26
@Velin92 Velin92 requested review from stefanceriu and removed request for a team November 6, 2025 15:26
@Velin92 Velin92 force-pushed the mauroromito/handle_pinned_events_in_threads branch from 0a387cc to 1aed157 Compare November 6, 2025 15:26
Velin92
Velin92 commented Nov 6, 2025
View reviewed changes
@stefanceriu stefanceriu requested review from pixlwave and removed request for stefanceriu November 7, 2025 10:53
pixlwave
pixlwave approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this handled quickly 😎

@Velin92 Velin92 force-pushed the mauroromito/handle_pinned_events_in_threads branch from 4cc1b85 to d17efc8 Compare November 10, 2025 11:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Velin92 Velin92 merged commit 2ccbe52 into develop Nov 10, 2025
7 of 8 checks passed
@Velin92 Velin92 deleted the mauroromito/handle_pinned_events_in_threads branch November 10, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees

No one assigned

Labels

pr-wip for anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task] View pinned threaded event

3 participants

@Velin92 @pixlwave