Skip to content

Missing timeline history (Scrollback getting completely lost) #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ara4n opened this issue Apr 4, 2024 · 2 comments
Closed

Missing timeline history (Scrollback getting completely lost) #2650

ara4n opened this issue Apr 4, 2024 · 2 comments
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Apr 4, 2024

Steps to reproduce

In build 566, view a room. Chances are that large hunks of history will go missing, and new messages may not arrive. Going to room list and back again fixes it.

Outcome

What did you expect?

Reliable timeline

What happened instead?

Deeply unreliable timeline

Your phone model

No response

Operating system version

No response

Application version

566

Homeserver

No response

Will you send logs?

Yes

@ara4n ara4n added the T-Defect label Apr 4, 2024
@Velin92 Velin92 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Timeline X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue labels Apr 5, 2024
@ara4n ara4n changed the title Scrollback getting completely lost Missing timeline history (Scrollback getting completely lost) Apr 10, 2024
@bnjbvr
Copy link
Member

bnjbvr commented Apr 11, 2024

So this is likely one instance of matrix-org/matrix-rust-sdk#3312 that happens a lot for coincidental reasons: sliding sync || synapse sending duplicate fully read marker events, causing the event cache to forward one "update" per fully read marker, spamming the Rust channel the timeline is listening to, and the timeline concluding that it may have missed important info, and clearing itself.

While the long-term general fix will likely be something like the above PR, the short-term fix is to have the event cache ignore duplicate read marker events for a given room, which this PR does, and that should avoid most instances of this bug for most people.

@stefanceriu
Copy link
Member

Fixed in matrix-org/matrix-rust-sdk#3321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

4 participants