Skip to content

Commit fe99ec0

Browse files
authored
runQualityChecks task shouldn't fail fast (#4309)
* `runQualityChecks` task shouldn't fail fast Make sure we run every task it depends on so we get a list with all the issues instead of having to retry several times. * Tweak `runQualityChecks` to make sure all Android lint tasks run * Use the right check in the quality flow * Fix Norwegian translations that caused a `Typos` error
1 parent 1bbcedf commit fe99ec0

File tree

3 files changed

+23
-6
lines changed

3 files changed

+23
-6
lines changed

.github/workflows/quality.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ jobs:
138138
- name: Build Fdroid Debug
139139
run: ./gradlew :app:compileFdroidDebugKotlin $CI_GRADLE_ARG_PROPERTIES
140140
- name: Run lint
141-
run: ./gradlew :app:lintGplayDebug :app:lintFdroidDebug $CI_GRADLE_ARG_PROPERTIES
141+
run: ./gradlew :app:lintGplayDebug :app:lintFdroidDebug lintDebug $CI_GRADLE_ARG_PROPERTIES --continue
142142
- name: Upload reports
143143
if: always()
144144
uses: actions/upload-artifact@v4

build.gradle.kts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,14 +166,17 @@ allprojects {
166166
// Register quality check tasks.
167167
tasks.register("runQualityChecks") {
168168
dependsOn(":tests:konsist:testDebugUnitTest")
169+
dependsOn(":app:lintGplayDebug")
169170
project.subprojects {
170-
// For some reason `findByName("lint")` doesn't work
171-
tasks.findByPath("$path:lint")?.let { dependsOn(it) }
171+
tasks.findByPath("$path:lintDebug")?.let { dependsOn(it) }
172172
tasks.findByName("detekt")?.let { dependsOn(it) }
173173
tasks.findByName("ktlintCheck")?.let { dependsOn(it) }
174174
// tasks.findByName("buildHealth")?.let { dependsOn(it) }
175175
}
176176
dependsOn(":app:knitCheck")
177+
178+
// Make sure all checks run even if some fail
179+
gradle.startParameter.isContinueOnFailure = true
177180
}
178181

179182
// Make sure to delete old screenshots before recording new ones

libraries/ui-strings/src/main/res/values-nb/translations.xml

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
<string name="a11y_pause">"Setter på pause"</string>
1010
<string name="a11y_pin_field">"PIN-felt"</string>
1111
<string name="a11y_play">"Spill av"</string>
12+
<string name="a11y_poll">"Avstemning"</string>
1213
<string name="a11y_poll_end">"Avsluttet avstemning"</string>
1314
<string name="a11y_react_with">"Reager med %1$s"</string>
1415
<string name="a11y_react_with_other_emojis">"Reager med andre emojier"</string>
@@ -143,14 +144,17 @@
143144
<string name="common_encryption_enabled">"Kryptering aktivert"</string>
144145
<string name="common_enter_your_pin">"Skriv inn PIN-koden din"</string>
145146
<string name="common_error">"Feil"</string>
147+
<string name="common_everyone">"Alle"</string>
146148
<string name="common_failed">"Mislyktes"</string>
147149
<string name="common_favourite">"Favoritt"</string>
148150
<string name="common_file">"Fil"</string>
149151
<string name="common_file_saved_on_disk_android">"Fil lagret i Nedlastinger"</string>
152+
<string name="common_forward_message">"Videresend melding"</string>
150153
<string name="common_gif">"GIF"</string>
151154
<string name="common_image">"Bilde"</string>
152155
<string name="common_in_reply_to">"Som svar på %1$s"</string>
153156
<string name="common_install_apk_android">"Installer APK"</string>
157+
<string name="common_invite_unknown_profile">"Finner ikke denne Matrix-IDen, så invitasjonen blir kanskje ikke mottatt."</string>
154158
<string name="common_leaving_room">"Forlater rommet"</string>
155159
<string name="common_light">"Lys"</string>
156160
<string name="common_link_copied_to_clipboard">"Lenke kopiert til utklippstavlen"</string>
@@ -220,6 +224,7 @@
220224
<string name="common_syncing">"Synkroniserer"</string>
221225
<string name="common_system">"System"</string>
222226
<string name="common_text">"Tekst"</string>
227+
<string name="common_third_party_notices">"Varsler fra tredjeparter"</string>
223228
<string name="common_thread">"Tråd"</string>
224229
<string name="common_topic">"Emne"</string>
225230
<string name="common_topic_placeholder">"Hva er dette rommet for?"</string>
@@ -250,21 +255,30 @@
250255
<string name="dialog_unsaved_changes_description_android">"Endringene dine er ikke lagret. Er du sikker på at du vil gå tilbake?"</string>
251256
<string name="dialog_unsaved_changes_title">"Lagre endringer?"</string>
252257
<string name="error_failed_creating_the_permalink">"Opprettelse av permalenken mislyktes"</string>
258+
<string name="error_failed_loading_map">"%1$s kunne ikke laste inn kartet. Prøv igjen senere."</string>
253259
<string name="error_failed_loading_messages">"Kunne ikke laste inn meldinger"</string>
260+
<string name="error_failed_locating_user">"%1$s fikk ikke tilgang til lokasjonen din. Vennligst prøv igjen senere."</string>
261+
<string name="error_missing_location_auth_android">"%1$s har ikke tilgang til lokasjonen din. Du kan aktivere tilgang i Innstillinger."</string>
262+
<string name="error_missing_location_rationale_android">"%1$s har ikke tilgang til lokasjonen din. Aktiver tilgang nedenfor."</string>
254263
<string name="error_some_messages_have_not_been_sent">"Noen meldinger er ikke sendt"</string>
255264
<string name="error_unknown">"Beklager, det oppstod en feil"</string>
256265
<string name="event_shield_reason_sent_in_clear">"Ikke kryptert."</string>
257266
<string name="invite_friends_rich_title">"🔐️ Bli med meg på %1$s"</string>
258267
<string name="invite_friends_text">"Hei, snakk med meg på %1$s: %2$s"</string>
259268
<string name="login_initial_device_name_android">"%1$s Android"</string>
260269
<string name="screen_media_picker_error_failed_selection">"Kunne ikke velge medium, prøv igjen."</string>
261-
<string name="screen_media_upload_preview_error_failed_processing">"Kunne ikke behandle media for opplasting, vennligst prøv igjen."</string>
262-
<string name="screen_media_upload_preview_error_failed_sending">"Opplasting av media mislyktes, vennligst prøv igjen."</string>
263-
<string name="screen_room_error_failed_processing_media">"Kunne ikke behandle media for opplasting, vennligst prøv igjen."</string>
270+
<string name="screen_media_upload_preview_error_failed_processing">"Kunne ikke behandle medier for opplasting, vennligst prøv igjen."</string>
271+
<string name="screen_media_upload_preview_error_failed_sending">"Opplasting av medier mislyktes, vennligst prøv igjen."</string>
272+
<string name="screen_room_error_failed_processing_media">"Kunne ikke behandle medier for opplasting, vennligst prøv igjen."</string>
264273
<string name="screen_room_error_failed_retrieving_user_details">"Kunne ikke hente brukerdetaljer"</string>
274+
<string name="screen_share_location_title">"Del lokasjon"</string>
275+
<string name="screen_share_my_location_action">"Del min lokasjon"</string>
265276
<string name="screen_share_open_apple_maps">"Åpne i Apple Maps"</string>
266277
<string name="screen_share_open_google_maps">"Åpne i Google Maps"</string>
278+
<string name="screen_share_open_osm_maps">"Åpne i OpenStreetMap"</string>
279+
<string name="screen_share_this_location_action">"Del denne lokasjonen"</string>
267280
<string name="screen_timeline_item_menu_send_failure_unsigned_device">"Meldingen ble ikke sendt fordi %1$s ikke har verifisert alle enheter."</string>
281+
<string name="screen_view_location_title">"Lokasjon"</string>
268282
<string name="settings_version_number">"Versjon: %1$s (%2$s)"</string>
269283
<string name="test_language_identifier">"en"</string>
270284
</resources>

0 commit comments

Comments
 (0)