Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Never send encrypted messages to unverified devices from this device" is confusing wording #10748

Open
lampholder opened this issue Sep 4, 2019 · 3 comments
Labels
Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed P2 T-Defect

Comments

@lampholder
Copy link
Member

lampholder commented Sep 4, 2019

It would be better to be "Only send encrypted messages to verified devices from this device."

@jryans jryans added defect Help Wanted Extra attention is needed P2 labels Sep 23, 2019
@turt2live
Copy link
Member

ftr this was intentionally skipped during the affirmative sprint because of the complexity involved in changing the behaviour. It's one of the few tied into the js-sdk, which makes it difficult to rename/fallback like the others.

@jryans jryans removed the defect label Mar 4, 2021
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
@richvdh richvdh changed the title Phrase setting in the affirmative: Never send encrypted messages to unverified devices from this device "Never send encrypted messages to unverified devices from this device" is confusing wording Jan 21, 2025
@richvdh
Copy link
Member

richvdh commented Jan 21, 2025

This setting is still present as of today, on the "Security & Privacy" tab:

Image

... though I guess it's going to be removed from there as part of #26468.

It's also present at the room level, where afaik there are no plans to remove it.

Image

It will, I think, be made completely redundant by matrix-org/matrix-spec-proposals#4153 (aka the "Exclude insecure devices when sending/receiving messages" labs flag).

Aside:

ftr this was intentionally skipped during the affirmative sprint because of the complexity involved in changing the behaviour. It's one of the few tied into the js-sdk, which makes it difficult to rename/fallback like the others.

I don't understand this. AFAICT this issue only proposes to change the label, not the impl?

@turt2live
Copy link
Member

The "affirmative sprint" was an effort to change all of our settings to be written in an affirmative way ("Don't send messages" default off -> "Send messages" default on). From memory, trying to change the label to be in the positive was complicated at the time because it was routed outside the SettingsStore, and the inverse language wasn't really representative of what we were thinking at the time.

An easy no-op change might be to rephrase it as "Only send to verified devices", but I honestly don't recall why we didn't do that in 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed P2 T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants