Stop using Vitest globals

Vitest provides globals primarily to make the transition from Jest more smooth. But importing its functions explicitly is considered a better pattern, and we have so few tests right now that it's trivial to migrate them all.

Author: robintown

src/Toast.test.tsx

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import { vi } from "vitest";
+import { expect, test, vi } from "vitest";
 import { screen, render } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 

src/UrlParams.test.ts

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import { vi } from "vitest";
+import { beforeAll, describe, expect, it, vi } from "vitest";
 
 import { getRoomIdentifierFromUrl } from "../src/UrlParams";
 import { Config } from "../src/config/Config";

src/home/CallList.test.tsx

@@ -17,6 +17,7 @@ limitations under the License.
 import { render, RenderResult } from "@testing-library/react";
 import { MatrixClient } from "matrix-js-sdk";
 import { MemoryRouter } from "react-router-dom";
+import { describe, expect, it } from "vitest";
 
 import { CallList } from "../../src/home/CallList";
 import { GroupCallRoom } from "../../src/home/useGroupCallRooms";

src/initializer.test.ts

@@ -14,6 +14,8 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+import { expect, test } from "vitest";
+
 import { Initializer } from "../src/initializer";
 
 test("initBeforeReact sets font family from URL param", () => {

src/otel/ObjectFlattener.test.ts

@@ -20,6 +20,7 @@ import {
   ByteSentStatsReport,
   ConnectionStatsReport,
 } from "matrix-js-sdk/src/webrtc/stats/statsReport";
+import { describe, expect, it } from "vitest";
 
 import { ObjectFlattener } from "../../src/otel/ObjectFlattener";
 

src/room/checkForParallelCalls.test.ts

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import { vi, Mocked } from "vitest";
+import { vi, Mocked, test, expect } from "vitest";
 import { RoomState } from "matrix-js-sdk/src/models/room-state";
 
 import { PosthogAnalytics } from "../../src/analytics/PosthogAnalytics";

src/rtcSessionHelper.test.ts

@@ -15,6 +15,7 @@ limitations under the License.
 */
 
 import { MatrixRTCSession } from "matrix-js-sdk/src/matrixrtc/MatrixRTCSession";
+import { expect, test, vi } from "vitest";
 
 import { enterRTCSession } from "../src/rtcSessionHelpers";
 import { Config } from "../src/config/Config";

tsconfig.json

@@ -46,7 +46,6 @@
   },
   "include": [
     "./node_modules/matrix-js-sdk/src/@types/*.d.ts",
-    "./node_modules/vitest/globals.d.ts",
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ]

vitest.config.js

@@ -6,7 +6,6 @@ export default defineConfig((configEnv) =>
     viteConfig(configEnv),
     defineConfig({
       test: {
-        globals: true,
         environment: "jsdom",
         css: {
           modules: {