Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Server returns the URL of blockmap, blocking auto update #113

Closed
amatzen opened this issue Sep 12, 2022 · 1 comment · Fixed by #169
Closed

Update Server returns the URL of blockmap, blocking auto update #113

amatzen opened this issue Sep 12, 2022 · 1 comment · Fixed by #169

Comments

@amatzen
Copy link

amatzen commented Sep 12, 2022

Hi,

When using the hosted update.electronjs.org server, I get the blockmap URL in the url property of the response object, instead of the ZIP-file for the macOS distribution. This blocks the auto update function for us.

However, for a forked repo used for testing, I get the proper zip file in the url property.

https://update.electronjs.org/servicepos/printdesk/darwin-x64/v1.62.5
https://update.electronjs.org/amatzen/printdesk/darwin-x64/v1.62.5

I suspect the RegEx here to falsely turn positive on Printdesk-1.62.6-mac.zip.blockmap:

if (/.*(mac|darwin|osx).*\.zip/i.test(fileName) && !/arm64/.test(fileName)) {
return PLATFORM_ARCH.DARWIN_X64
}

@setchy
Copy link
Contributor

setchy commented Jan 3, 2025

Should be resolved now by #169

cc: @erikian @erickzhao

@erikian erikian linked a pull request Jan 3, 2025 that will close this issue
@erikian erikian closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants